linux-kernel - Re: [PATCH 3/4] kprobes/treewide: Explicitly override alloc/free functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZhoywPS0QqG0c6jw@li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com>
Date: Sat, 13 Apr 2024 09:22:40 +0200
From: Alexander Gordeev <agordeev@...ux.ibm.com>
To: Mark Rutland <mark.rutland@....com>
Cc: linux-kernel@...r.kernel.org, anil.s.keshavamurthy@...el.com,
        aou@...s.berkeley.edu, bp@...en8.de, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, davem@...emloft.net, gor@...ux.ibm.com,
        hca@...ux.ibm.com, jarkko@...nel.org, jcalvinowens@...il.com,
        linux-arm-kernel@...ts.infradead.org, mhiramat@...nel.org,
        mingo@...hat.com, mpe@...erman.id.au, naveen.n.rao@...ux.ibm.com,
        palmer@...belt.com, paul.walmsley@...ive.com, tglx@...utronix.de,
        will@...nel.org
Subject: Re: [PATCH 3/4] kprobes/treewide: Explicitly override alloc/free
 functions

On Tue, Mar 26, 2024 at 04:36:23PM +0000, Mark Rutland wrote:
Hi Mark,

..
> (a) Architectures using the generic kprobes_free_insn_page() and
                                      kprobes_alloc_insn_page()?
>     kprobes_free_insn_page() are left as-is. The __weak annotation is
>     removed from the generic implementations so that accidental
>     overrides/misuse can be detected easily.
> 
> (b) Architectures which provide their own kprobes_free_insn_page() are
                                            kprobes_alloc_insn_page()?
>     given a matching implementation of kprobes_free_insn_page(), and
>     select HAVE_KPROBES_ALLOC.
.
>  arch/s390/Kconfig                  | 3 ++-
>  arch/s390/kernel/kprobes.c         | 5 +++++

I tried the repo:
git://git.kernel.org/pub/scm/linux/kernel/git/mark/linux.git    kprobes/without-modules

For s390:
Acked-by: Alexander Gordeev <agordeev@...ux.ibm.com>

Thanks!