Message-ID: <20240413171409.4575fe6f@jic23-huawei>
Date: Sat, 13 Apr 2024 17:14:09 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: David Lechner <dlechner@...libre.com>, Marcelo Schmitt
 <marcelo.schmitt@...log.com>, lars@...afoo.de,
 Michael.Hennerich@...log.com, robh+dt@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: iio: adc: Add AD4000

On Tue, 9 Apr 2024 12:30:09 -0300
Marcelo Schmitt <marcelo.schmitt1@...il.com> wrote:

> On 04/08, David Lechner wrote:
> > On Mon, Apr 8, 2024 at 9:32 AM Marcelo Schmitt
> > <marcelo.schmitt@...log.com> wrote:  
> > >
> > > Add device tree documentation for AD4000 family of ADC devices.
> > >
> > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4000-4004-4008.pdf
> > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4001-4005.pdf
> > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4002-4006-4010.pdf
> > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4003-4007-4011.pdf
> > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/ad4020-4021-4022.pdf
> > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4001.pdf
> > > Datasheet: https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4003.pdf
> > >  
> > 
> > Suggested-by: David Lechner <dlechner@...libre.com>
> > 
> > (if you still use mostly my suggestions in the end)  
> 
> Yes, it's been of great help. Will include the tag in future ad4000 DT patches.
> 
> >   
> > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@...log.com>
> > > ---
> > >  .../bindings/iio/adc/adi,ad4000.yaml          | 201 ++++++++++++++++++
> > >  MAINTAINERS                                   |   7 +
> > >  2 files changed, 208 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> > > new file mode 100644
> > > index 000000000000..ca06afb5149e
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4000.yaml
> > > @@ -0,0 +1,201 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/iio/adc/adi,ad4000.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Analog Devices AD4000 and similar Analog to Digital Converters
> > > +
> > > +maintainers:
> > > +  - Marcelo Schmitt <marcelo.schmitt@...log.com>
> > > +
> > > +description: |
> > > +  Analog Devices AD4000 family of Analog to Digital Converters with SPI support.
> > > +  Specifications can be found at:
> > > +    https://www.analog.com/media/en/technical-documentation/data-sheets/ad4000-4004-4008.pdf
> > > +    https://www.analog.com/media/en/technical-documentation/data-sheets/ad4001-4005.pdf
> > > +    https://www.analog.com/media/en/technical-documentation/data-sheets/ad4002-4006-4010.pdf
> > > +    https://www.analog.com/media/en/technical-documentation/data-sheets/ad4003-4007-4011.pdf
> > > +    https://www.analog.com/media/en/technical-documentation/data-sheets/ad4020-4021-4022.pdf
> > > +    https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4001.pdf
> > > +    https://www.analog.com/media/en/technical-documentation/data-sheets/adaq4003.pdf
> > > +
> > > +$ref: /schemas/spi/spi-peripheral-props.yaml#
> > > +
> > > +properties:
> > > +  compatible:
> > > +    enum:
> > > +      - adi,ad4000
> > > +      - adi,ad4001
> > > +      - adi,ad4002
> > > +      - adi,ad4003
> > > +      - adi,ad4004
> > > +      - adi,ad4005
> > > +      - adi,ad4006
> > > +      - adi,ad4007
> > > +      - adi,ad4008
> > > +      - adi,ad4010
> > > +      - adi,ad4011
> > > +      - adi,ad4020
> > > +      - adi,ad4021
> > > +      - adi,ad4022
> > > +      - adi,adaq4001
> > > +      - adi,adaq4003
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +  spi-max-frequency:
> > > +    maximum: 102040816 # for VIO > 2.7 V, 81300813 for VIO > 1.7 V
> > > +
> > > +  spi-cpha: true
> > > +
> > > +  adi,spi-mode:
> > > +    $ref: /schemas/types.yaml#/definitions/string
> > > +    enum: [ single, chain ]  
> > 
> > It sounds like there are more possible wiring configurations for these
> > chips that I thought when suggesting reusing this binding from AD7944
> > so we probably need more options here. (see my reply to the cover
> > letter for the complete context of these remarks)
> > 
> > We identified A) an additional wiring configuration where SDI of the
> > ADC chip is wired to SDO of the SPI controller and B) a potential need
> > to pin mux between wiring modes to work around SPI controller
> > limitations perhaps we could omit the adi,spi-mode property and just
> > use the standard pinctrl properties.
> > 
> >   pinctrl-names:

I'm lost on how pinctrl makes sense here.
Yes you are changing the modes of the pins, but not in a conventional sense
of some register that is being updated to say now use them like this.
The mode is dependent on the timing sequence of how the pins are used.
Otherwise looking at it a different way it's an external wiring thing we
aren't controlling it at all.  Is pinctrl suitable for that?
I always thought of it as a way to change configurations of SoC pins.

A pointer to some precendence in another driver for using it like this
would go some way towards convincing me.

Jonathan


> >     description: |
> >       Names for possible ways the SDI line of the controller is wired.
> > 
> >       * default: The SDI line of the ADC is connected to the SDO line of the
> >         SPI controller.  CNV line of the ADC is connected to CS of the SPI
> >         controller.  
> Not sure if should be DT, but maybe also point out that in default mode the
> SPI controller must be capable of keeping ADC SDI (controller SDO) line high
> during ADC conversions.
> 
> >       * single: The datasheet calls this "3-wire mode".  (NOTE: The datasheet's
> >         definition of 3-wire mode is NOT at all related to the standard
> >         spi-3wire property!)  In this mode, SDI is tied to VIO, and the CNV line
> >         can be connected to the CS line of the SPI controller (typical) or to a
> >         GPIO, in which case the CS line of the controller is unused.  The SDO
> >         line of the SPI controller is not connected.
> >       * multi: The datasheet calls this "4-wire mode" and is used when multiple
> >         chips are connected in parallel.  In this mode, the ADC SDI line is tied
> >         to the CS line on the SPI controller and the CNV line is connected to
> >         a GPIO.  The SDO line of the SPI controller is not connected.
> >       * chain: The datasheet calls this "chain mode".  This mode is used to save
> >         on wiring when multiple ADCs are used.  In this mode, the SDI line of
> >         one chip is tied to the SDO of the next chip in the chain and the SDI of
> >         the last chip in the chain is tied to GND.  Only the first chip in the
> >         chain is connected to the SPI bus.  The CNV line of all chips are tied
> >         together.  The CS line of the SPI controller can be used as the CNV line
> >         only if it is active high.
> > 
> >       If one name is specified, it is assumed the chip is hard-wired in this
> >       configuration.
> > 
> >       If two names are specified, it is assumed that a pinmux can switch between
> >       the two wiring configurations.  The first is the default mode for reading
> >       and writing registers on the chip and the second is the mode for reading
> >       the conversion data from the chip.
> >     oneOf:
> >       - items:
> >           - enum:
> >             - default
> >             - single
> >             - multi
> >             - chain
> >       - items:
> >           - const: default
> >           - enum:
> >             - single
> >             - multi
> >             - chain
> > 
> >   pinctrl-0:
> >     maxItems: 1
> > 
> >   pinctrl-1:
> >     maxItems: 1

Powered by blists - more mailing lists