linux-kernel - Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 13 Apr 2024 20:26:48 +0000
From: "Haener, Michael" <michael.haener@...mens.com>
To: "linux-integrity@...r.kernel.org" <linux-integrity@...r.kernel.org>,
	"krzk@...nel.org" <krzk@...nel.org>
CC: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>,
	"jarkko@...nel.org" <jarkko@...nel.org>, "jgg@...pe.ca" <jgg@...pe.ca>,
	"peterhuewe@....de" <peterhuewe@....de>, "robh@...nel.org" <robh@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"lukas@...ner.de" <lukas@...ner.de>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS
 binding

On Sat, 2024-04-13 at 10:38 +0200, Krzysztof Kozlowski wrote:
> On 13/04/2024 09:15, M. Haener wrote:
> > From: Michael Haener <michael.haener@...mens.com>
> >
> > Add the ST chip st33ktpm2xi2c to the supported compatible strings
> > of the
> > TPM TIS I2C schema. The Chip is compliant with the TCG PC Client
> > TPM
> > Profile specification.
> >
> > For reference, a datasheet is available at:
> > https://www.st.com/resource/en/data_brief/st33ktpm2xi2c.pdf
> >
> > Reviewed-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>
> > Signed-off-by: Michael Haener <michael.haener@...mens.com>
> > ---
>
>
> Not tested...

I was only able to verify and test the conformity of the ST chip
st33ktpm2xi2c with kernel 6.1, so I left out the test-by tag.
Unfortunately, there is no newer kernel for my embedded hardware.

>
> Please use scripts/get_maintainers.pl to get a list of necessary
> people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
> people, so fix your workflow. Tools might also fail if you work on
> some
> ancient tree (don't, instead use mainline), work on fork of kernel
> (don't, instead use mainline) or you ignore some maintainers (really
> don't). Just use b4 and everything should be fine, although remember
> about `b4 prep --auto-to-cc` if you added new patches to the
> patchset.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling.

I called the script scripts/get_maintainer.pl on the latest kernel
version for each of the two patches and added the output list to the
individual patches accordingly. And only for the cover-letter I linked
the two lists together.
I understand now that I should have sent the whole series to both
lists.

>
> Please kindly resend and include all necessary To/Cc entries.
>
> Best regards,
> Krzysztof
>

Best regards,
Michael