linux-kernel - Re: [RFC PATCH v2 2/6] dt-bindings: mfd: bd96801 PMIC core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5eeaf10-e011-452b-840a-176c4f62cac4@linaro.org>
Date: Sat, 13 Apr 2024 23:33:50 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Matti Vaittinen <mazziesaccount@...il.com>,
 Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Liam Girdwood <lgirdwood@...il.com>,
 Mark Brown <broonie@...nel.org>, Wim Van Sebroeck <wim@...ux-watchdog.org>,
 Guenter Roeck <linux@...ck-us.net>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-watchdog@...r.kernel.org,
 Fabio Aiuto <fabio.aiuto@...icam.com>
Subject: Re: [RFC PATCH v2 2/6] dt-bindings: mfd: bd96801 PMIC core

On 12/04/2024 13:21, Matti Vaittinen wrote:
> ROHM BD96801 is a highly configurable automotive grade PMIC. Introduce
> DT bindings for the BD96801 core.
> 
> Signed-off-by: Matti Vaittinen <mazziesaccount@...il.com>
> 
> ---
> Revision history:
> RFCv1 => RFCv2:
>   - Document rohm,hw-timeout-ms
>   - Document rohm,wdg-action
> ---
>  .../bindings/mfd/rohm,bd96801-pmic.yaml       | 171 ++++++++++++++++++
>  1 file changed, 171 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> 
> diff --git a/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> new file mode 100644
> index 000000000000..31ef787d6a8a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/rohm,bd96801-pmic.yaml
> @@ -0,0 +1,171 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/rohm,bd96801-pmic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ROHM BD96801 Scalable Power Management Integrated Circuit
> +
> +maintainers:
> +  - Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> +
> +description: |

Do not need '|' unless you need to preserve formatting.

> +  BD96801 is an automotive grade single-chip power management IC.
> +  It integrates 4 buck converters and 3 LDOs with safety features like
> +  over-/under voltage and over current detection and a watchdog.
> +
> +properties:
> +  compatible:
> +    const: rohm,bd96801
> +
> +  reg:
> +    description:
> +      I2C slave address.

Drop description, obvious.

> +    maxItems: 1
> +
> +  interrupts:
> +    description:
> +      The PMIC provides intb and errb IRQ lines. The errb IRQ line is used
> +      for fatal IRQs which will cause the PMIC to shut down power outputs.
> +      In many systems this will shut down the SoC contolling the PMIC and
> +      connecting/handling the errb can be omitted. However, there are cases
> +      where the SoC is not powered by the PMIC. In that case it may be
> +      useful to connect the errb and handle errb events.
> +    minItems: 1
> +    maxItems: 2
> +
> +  interrupt-names:
> +    minItems: 1
> +    items:
> +      - enum: [intb, errb]
> +      - const: errb
> +
> +  rohm,hw-timeout-ms:
> +    description:
> +      Watchdog timeout value(s). First walue is timeout limit. Second value is
> +      optional value for 'too early' watchdog ping if window timeout mode is
> +      to be used.

Standard property timeout-sec does not work for you? It should allow two
items as well.

> +    minItems: 1
> +    maxItems: 2
> +
> +  rohm,wdg-action:
> +    description:
> +      Whether the watchdog failure must turn off the regulator power outputs or
> +      just toggle the INTB line.
> +    enum:
> +      - prstb
> +      - intb-only

This is second property controlling bite behavior. The other being:
https://lore.kernel.org/all/e86812b3-a3aa-4bdb-9b32-a0339f0f76b5@kernel.org/

Probably we need common property in watchdog.yaml.

> +
> +  regulators:
> +    $ref: ../regulator/rohm,bd96801-regulator.yaml

Full path, so /schemas/regulator/....

> +    description:
> +      List of child nodes that specify the regulators.
> +
> +required:
> +  - compatible
> +  - reg
> +  - interrupts
> +  - interrupt-names
> +  - regulators
> +

Missing allOf and $ref to watchdog.yaml

> +additionalProperties: false
> +
> +examples:


Best regards,
Krzysztof