[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <79bef664-b191-4905-896c-afab341b982b@wanadoo.fr>
Date: Sun, 14 Apr 2024 10:03:07 +0200
From: Christophe JAILLET <christophe.jaillet@...adoo.fr>
To: Chanh Nguyen <chanh@...amperecomputing.com>,
Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>,
Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Justin Ledford
<justinledford@...gle.com>, devicetree@...r.kernel.org,
linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
Open Source Submission <patches@...erecomputing.com>
Cc: Phong Vo <phong@...amperecomputing.com>,
Thang Nguyen <thang@...amperecomputing.com>,
Quan Nguyen <quan@...amperecomputing.com>
Subject: Re: [PATCH v2 2/3] hwmon: (max31790): Support config PWM output
becomes TACH
Le 14/04/2024 à 06:22, Chanh Nguyen a écrit :
> PWMOUT pins on MAX31790 can be configured as a tachometer input pin by
> setting bit[0] in the Configuration Register. When the bit[0] of a channel
> is set, the PWMOUT pin becomes the tach input pin for the channel plus six.
>
> This commit allows the kernel to set those pins when necessary if the
> maxim,pwmout-pin-as-tach-input DT property exists.
>
> Signed-off-by: Chanh Nguyen <chanh@...amperecomputing.com>
> ---
> Changes in v2:
> - Update the vendor property name to "maxim,pwmout-pin-as-tach-input" [Rob]
..
> @@ -528,6 +532,33 @@ static int max31790_probe(struct i2c_client *client)
> if (err)
> return err;
>
> + if (device_property_present(dev, "maxim,pwmout-pin-as-tach-input")) {
> + err = device_property_read_u8_array(dev, "maxim,pwmout-pin-as-tach-input",
> + pwmout_to_tach, NR_CHANNEL);
> + if (err) {
> + /* The maxim,pwmout-pin-as-tach-input is an array of six values */
> + dev_warn(dev, "The maxim,pwmout-pin-as-tach-input property exist but malform");
Nit: exists
Nit: malformed or "is malformed"
CJ
Powered by blists - more mailing lists