linux-kernel - Re: [PATCH 2/4] clk: ep93xx: add DT support for Cirrus EP93xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1133974853f647ce1e575ac064e90fa852ce535b.camel@maquefel.me>
Date: Sun, 14 Apr 2024 12:35:00 +0300
From: Nikita Shubin <nikita.shubin@...uefel.me>
To: Stephen Boyd <sboyd@...nel.org>, Alexander Sverdlin
 <alexander.sverdlin@...il.com>, Conor Dooley <conor+dt@...nel.org>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, Michael Turquette
 <mturquette@...libre.com>, Nikita Shubin via B4 Relay
 <devnull+nikita.shubin.maquefel.me@...nel.org>, Rob Herring
 <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, linux-clk@...r.kernel.org, 
	devicetree@...r.kernel.org, Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH 2/4] clk: ep93xx: add DT support for Cirrus EP93xx

Hello Stephen!

All notes taken in account, except: 

On Thu, 2024-04-11 at 02:32 -0700, Stephen Boyd wrote:
> Quoting Nikita Shubin via B4 Relay (2024-04-08 01:09:54)
> > 
> > +       ret = clk_hw_register_div(clk, "ep93xx-adc", &xtali,
> 
> Use devm?

This clk-ep93xx internal function and it uses devm:

```
static int clk_hw_register_div(...)
..
	return devm_clk_hw_register(priv->dev, &clk->hw);
```