linux-kernel - Re: [PATCH] staging: vc04_services: Code optimized to use linux BIT macro.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 14 Apr 2024 12:17:56 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: sumadhura kalyan <opensourcecond@...il.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: vc04_services: Code optimized to use linux BIT
 macro.

On Sun, Apr 14, 2024 at 03:42:58PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
> 
> Signed-off-by: sumadhura kalyan <opensourcecond@...il.com>
> ---
>  drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> index a0cdd28101f2..d811bfd3bb84 100644
> --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-parameters.h
> @@ -27,7 +27,7 @@
>  /** Common parameter ID group, used with many types of component. */
>  #define MMAL_PARAMETER_GROUP_COMMON		(0 << 16)
>  /** Camera-specific parameter ID group. */
> -#define MMAL_PARAMETER_GROUP_CAMERA		(1 << 16)
> +#define MMAL_PARAMETER_GROUP_CAMERA		BIT(16)
>  /** Video-specific parameter ID group. */
>  #define MMAL_PARAMETER_GROUP_VIDEO		(2 << 16)
>  /** Audio-specific parameter ID group. */

When looking at the code now, does this change make sense?  Remember,
checkpatch is a guide, not a hard rule.

greg k-h