linux-kernel - Re: [PATCH v2] staging: vc04_services: Reformatted code according to Kernel Documents.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a3c1d471-849b-4d4d-8657-4ad73493fca2@moroto.mountain>
Date: Sun, 14 Apr 2024 15:01:14 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: sumadhura kalyan <opensourcecond@...il.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	gregkh@...uxfoundation.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: vc04_services: Reformatted code according to
 Kernel Documents.

The subject is too vague.

On Sun, Apr 14, 2024 at 05:21:06PM +0530, sumadhura kalyan wrote:
> Issue found by checkpatch
  ^^^^^^^^^^^^^^^^^^^^^^^^^
What issue?

A better commit message would be:

==================
Subject: [PATCH v3] staging: vc04_services: re-align function parameters

Checkpatch complains that:

CHECK: Lines should not end with a '('
#45: FILE: drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.h:45:
+typedef void (*vchiq_mmal_buffer_cb)(

Re-align the function parameters to make checkpatch happy.
================

> 
> Signed-off-by: sumadhura kalyan <opensourcecond@...il.com>
                 ^         ^
You should make these capital letters...  It's supposed to look formal
like you're signing a legal document.

regards,
dan carpenter