linux-kernel - Re: [PATCH 2/2] arm64: dts: rockchip: Add Radxa ZERO 3W/3E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cbcd0cf9-9e2a-43cd-afe8-844b513e3a7b@linaro.org>
Date: Sun, 14 Apr 2024 16:11:24 +0200
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jonas Karlman <jonas@...boo.se>, Heiko Stuebner <heiko@...ech.de>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: Add Radxa ZERO 3W/3E

On 14/04/2024 15:56, Jonas Karlman wrote:
> Hi Krzysztof,
> 
> On 2024-04-14 15:33, Krzysztof Kozlowski wrote:
>> On 14/04/2024 15:15, Jonas Karlman wrote:
>>> The Radxa ZERO 3W/3E is an ultra-small, high-performance single board
>>> computer based on the Rockchip RK3566, with a compact form factor and
>>> rich interfaces.
>>>
>>> The ZERO 3W and ZERO 3E are basically the same size and model, but
>>> differ only in storage and network interfaces.
>>>
>>> - eMMC (3W)
>>> - SD-card (both)
>>> - Ethernet (3E)
>>> - WiFi/BT (3W)
>>>
>>> This adds initial support for eMMC, SD-card, Ethernet, HDMI and USB.
>>>
>>> Signed-off-by: Jonas Karlman <jonas@...boo.se>
>>> ---
>>>  .../dts/rockchip/rk3566-radxa-zero-3e.dts     |  41 ++
>>>  .../dts/rockchip/rk3566-radxa-zero-3w.dts     |  26 +
>>>  .../boot/dts/rockchip/rk3566-radxa-zero3.dtsi | 443 ++++++++++++++++++
>>>  3 files changed, 510 insertions(+)
>>
>> How do you build your patches? That's rhetorical, because they cannot be
>> built... Missing Makefile.
> 
> They where built using the generic .dtb-file make target, will include
> in Makefile in v2, thanks.
> 
>>
>> Are you sure therefore that your dts pass dtbs_check? If this is not in
>> Makefile, how did you run the command?
> 
> I built and tested dts files using the following make commands:
> 
> make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 defconfig
> make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 CHECK_DTBS=y rockchip/rk3566-radxa-zero-3w.dtb
> make CROSS_COMPILE=aarch64-linux-gnu- ARCH=arm64 CHECK_DTBS=y rockchip/rk3566-radxa-zero-3e.dtb

OK, thanks, wasn't sure it works without makefile. Anyway you still need it.

Best regards,
Krzysztof