linux-kernel - Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 14 Apr 2024 21:12:52 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Arınç ÜNAL <arinc.unal@...nc9.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Florian Fainelli <f.fainelli@...il.com>,
 Hauke Mehrtens <hauke@...ke-m.de>, Rafal Milecki <zajec5@...il.com>,
 Florian Fainelli <florian.fainelli@...adcom.com>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Cc: Tom Brautaset <tbrautaset@...il.com>, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 3/4] ARM: dts: BCM5301X: Add DT for ASUS RT-AC3200

On 14/04/2024 18:59, Arınç ÜNAL wrote:
>>> +	};
>>> +
>>> +	memory@0 {
>>> +		device_type = "memory";
>>> +		reg = <0x00000000 0x08000000>,
>>> +		      <0x88000000 0x08000000>;
>>> +	};
>>> +
>>> +	nvram@...80000 {
>>> +		compatible = "brcm,nvram";
>>> +		reg = <0x1c080000 0x00180000>;
>>
>> Why is this outside of soc? Both soc node and soc DTSI?
> 
> I don't maintain the SoC device tree files so I don't know. The nvram node
> doesn't exist on any of the device tree files included by this device tree.

There are two problems here:
1. This looks like SoC component and such should not be in board DTS.
Regardless whether you maintain something or not, you should not add
incorrect code. Unless this is correct code, but then please share some
details.

2. You cannot have MMIO node outside of soc. That's a W=1 warning.

Best regards,
Krzysztof