linux-kernel - Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS binding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca685f5b60ac676a72b80b65b73b33d532617acd.camel@siemens.com>
Date: Sun, 14 Apr 2024 05:42:07 +0000
From: "Haener, Michael" <michael.haener@...mens.com>
To: "lukas@...ner.de" <lukas@...ner.de>, "krzysztof.kozlowski@...aro.org"
	<krzysztof.kozlowski@...aro.org>
CC: "jgg@...pe.ca" <jgg@...pe.ca>, "jarkko@...nel.org" <jarkko@...nel.org>,
	"peterhuewe@....de" <peterhuewe@....de>, "linux-integrity@...r.kernel.org"
	<linux-integrity@...r.kernel.org>, "robh@...nel.org" <robh@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
Subject: Re: [PATCH 2/2] dt-bindings: tpm: Add st,st33ktpm2xi2c to TCG TIS
 binding

On Sat, 2024-04-13 at 13:01 +0200, Krzysztof Kozlowski wrote:
> On 13/04/2024 12:56, Lukas Wunner wrote:
> > On Sat, Apr 13, 2024 at 12:53:25PM +0200, Krzysztof Kozlowski
> > wrote:
> > > On 13/04/2024 12:51, Lukas Wunner wrote:
> > > > The binding requires two entries in the compatible string used
> > > > in the DT,
> > > > the chip name followed by the generic string:
> > > > 
> > > >         items:
> > > >           - enum:
> > > >               - infineon,slb9673
> > > >               - nuvoton,npct75x
> > > >           - const: tcg,tpm-tis-i2c
> > > > 
> > > > This allows us to deal with device-specific quirks, should they
> > > > pop up
> > > > (e.g. special timing requirements, hardware bugs).  We don't
> > > > know in
> > > > advance if they will be discovered, but if they are, it's
> > > > cumbersome
> > > > to determine after the fact which products (and thus DTs) are
> > > > affected.
> > > > So having the name of the actual chip used on the board has
> > > > value.
> > > 
> > > So you say devices are compatible. Then the second patch is
> > > wrong.
> > > 
> > > I cannot respond to it, though... so NAK-here-for-second-patch.
> > 
> > I disagree.  It's ugly to have inconsistencies between the DT
> > bindings
> > and the driver.  So I think patch [1/2] in this series is fine.
> 
> You are mixing different things. This patchset creates inconsistency.
> You even refer here to bindings while we discuss the driver...
> 
> Why this one driver is different than all other Linux drivers? Why do
> you keep pushing here entirely different behavior?
> 
> The devices are compatible, so growing match table is both redundant
> and
> confusing. That's everywhere. TPM is not different.
> 
> Best regards,
> Krzysztof
> 

Sorry for the mistakes made (kernel noob).
I made the patch for the driver analogous to the i2c-tpm of
infineon,slb9673 and nuvoton,npct75x. In the discussion I realize that
the compatibility is a duplication and should not be extended.

I now adjust the following in the series:
- correct cc receiver list
- delete driver patch with compatibility extension
- change commit title to "dt-bindings: tpm: Add st,st33ktpm2xi2c"

Best regards,
Michael