linux-kernel - Re: [PATCH] drm/xe/irq: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a10be737-2f2f-4132-9793-3a6a6adf90ea@intel.com>
Date: Mon, 15 Apr 2024 09:46:13 +0530
From: "Chauhan, Shekhar" <shekhar.chauhan@...el.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	<lucas.demarchi@...el.com>
CC: <ogabbay@...nel.org>, <thomas.hellstrom@...ux.intel.com>,
	<maarten.lankhorst@...ux.intel.com>, <mripard@...nel.org>,
	<tzimmermann@...e.de>, <airlied@...il.com>, <daniel@...ll.ch>,
	<intel-xe@...ts.freedesktop.org>, <dri-devel@...ts.freedesktop.org>,
	<linux-kernel@...r.kernel.org>, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] drm/xe/irq: remove unneeded semicolon


On 4/15/2024 08:57, Jiapeng Chong wrote:
> No functional modification involved.
>
> ./drivers/gpu/drm/xe/xe_irq.c:279:3-4: Unneeded semicolon.

Specifying a specific line number in a commit message might not be the 
most resilient approach as it could become outdated.

Maybe rewrite it as:
"Remove unnecessary semicolon in pick_engine_gt()"

With that,
Reviewed-by: Shekhar Chauhan <shekhar.chauhan@...el.com>
>
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8757
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   drivers/gpu/drm/xe/xe_irq.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_irq.c b/drivers/gpu/drm/xe/xe_irq.c
> index 996806353171..5b1a2f46a1b2 100644
> --- a/drivers/gpu/drm/xe/xe_irq.c
> +++ b/drivers/gpu/drm/xe/xe_irq.c
> @@ -276,7 +276,7 @@ static struct xe_gt *pick_engine_gt(struct xe_tile *tile,
>   			return tile->media_gt;
>   		default:
>   			break;
> -		};
> +		}
>   		fallthrough;
>   	default:
>   		return tile->primary_gt;

-- 
-shekhar