linux-kernel - Re: [PATCH] PCI/AER: Print error message as per the TODO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03f357e6c16d13924b705513446e4eac37e38a99.camel@perches.com>
Date: Mon, 15 Apr 2024 09:19:59 -0700
From: Joe Perches <joe@...ches.com>
To: Abhinav Jain <jain.abhinav177@...il.com>, mahesh@...ux.ibm.com, 
	oohall@...il.com, bhelgaas@...gle.com, linuxppc-dev@...ts.ozlabs.org, 
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: skhan@...uxfoundation.org, javier.carrasco.cruz@...il.com
Subject: Re: [PATCH] PCI/AER: Print error message as per the TODO

On Mon, 2024-04-15 at 16:10 +0000, Abhinav Jain wrote:
> Add a pr_err() to print the add device error in find_device_iter()
[]
> diff --git a/drivers/pci/pcie/aer.c b/drivers/pci/pcie/aer.c
[]
> @@ -885,7 +885,8 @@ static int find_device_iter(struct pci_dev *dev, void *data)
>  		/* List this device */
>  		if (add_error_device(e_info, dev)) {
>  			/* We cannot handle more... Stop iteration */
> -			/* TODO: Should print error message here? */
> +			pr_err("find_device_iter: Cannot handle more devices.
> +					Stopping iteration");

You are adding unnecessary whitespace after the period.
String concatenation keeps _all_ the whitespace.

The format is fine on a single line too.

Something like:

		pr_notice("%s: Cannot handle more devices - iteration stopped\n",
			  __func__);