linux-kernel - Re: [PATCH 00/11] Series to deliver Ethernets for STM32MP13

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <171292930694.2308702.12108714635472172661.robh@kernel.org>
Date: Mon, 15 Apr 2024 11:56:55 -0500
From: Rob Herring <robh@...nel.org>
To: Christophe Roullier <christophe.roullier@...s.st.com>
Cc: Rob Herring <robh+dt@...nel.org>, netdev@...r.kernel.org, 
 linux-stm32@...md-mailman.stormreply.com, 
 Eric Dumazet <edumazet@...gle.com>, 
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>, 
 "David S . Miller" <davem@...emloft.net>, 
 Alexandre Torgue <alexandre.torgue@...s.st.com>, 
 Maxime Coquelin <mcoquelin.stm32@...il.com>, 
 Richard Cochran <richardcochran@...il.com>, 
 linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Paolo Abeni <pabeni@...hat.com>, devicetree@...r.kernel.org, 
 Jakub Kicinski <kuba@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
 Mark Brown <broonie@...nel.org>, Jose Abreu <joabreu@...opsys.com>, 
 Liam Girdwood <lgirdwood@...il.com>
Subject: Re: [PATCH 00/11] Series to deliver Ethernets for STM32MP13

On Thu, 11 Apr 2024 16:36:47 +0200, Christophe Roullier wrote:
> STM32MP13 is STM32 SOC with 2 GMACs instances
> This board have 2 RMII phy:
>   -Ethernet1: RMII with crystal
>   -Ethernet2: RMII without crystal
> Rework dwmac glue to simplify management for next stm32
> Add support for PHY regulator
> 
> Christophe Roullier (11):
>   dt-bindings: net: add STM32MP13 compatible in documentation for stm32
>   dt-bindings: net: add phy-supply property for stm32
>   net: ethernet: stmmac: rework glue to simplify management for next
>     stm32
>   net: ethernet: stmmac: add management of stm32mp13 for stm32
>   net: ethernet: stmmac: stm32: update config management for phy wo
>     cristal
>   net: ethernet: stm32: clean the way to manage wol irqwake
>   net: ethernet: stmmac: stm32: support the phy-supply regulator binding
>   ARM: dts: stm32: add ethernet1 and ethernet2 support on stm32mp13
>   ARM: dts: stm32: add ethernet1/2 RMII pins for STM32MP13F-DK board
>   ARM: dts: stm32: add ethernet1 and ethernet2 for STM32MP135F-DK board
>   ARM: multi_v7_defconfig: Add MCP23S08 pinctrl support
> 
>  .../devicetree/bindings/net/stm32-dwmac.yaml  |  83 ++++++-
>  arch/arm/boot/dts/st/stm32mp13-pinctrl.dtsi   |  71 ++++++
>  arch/arm/boot/dts/st/stm32mp131.dtsi          |  31 +++
>  arch/arm/boot/dts/st/stm32mp133.dtsi          |  30 +++
>  arch/arm/boot/dts/st/stm32mp135f-dk.dts       |  48 ++++
>  arch/arm/configs/multi_v7_defconfig           |   1 +
>  .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 235 ++++++++++++------
>  7 files changed, 421 insertions(+), 78 deletions(-)
> 
> --
> 2.25.1
> 
> 
> 

My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade

New warnings running 'make CHECK_DTBS=y st/stm32mp135f-dk.dtb' for 20240411143658.1049706-1-christophe.roullier@...s.st.com:

arch/arm/boot/dts/st/stm32mp135f-dk.dtb: adc@...03000: 'ethernet@...0e000' does not match any of the regexes: '^adc@[0-9]+$', 'pinctrl-[0-9]+'
	from schema $id: http://devicetree.org/schemas/iio/adc/st,stm32-adc.yaml#