linux-kernel - Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to power-up transition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <535f3756-80d9-4599-bf73-a8785d18c399@kl.wtf>
Date: Mon, 15 Apr 2024 19:14:33 +0200
From: Kenny Levinsen <kl@...wtf>
To: Johan Hovold <johan@...nel.org>
Cc: lma@...omium.org, benjamin.tissoires@...hat.com, dianders@...omium.org,
 dtor@...omium.org, hdegoede@...hat.com, jikos@...nel.org,
 johan+linaro@...nel.org, kai.heng.feng@...onical.com,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 mripard@...nel.org, rad@...omium.org
Subject: Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to
 power-up transition

On 4/15/24 3:22 PM, Johan Hovold wrote:
> We also use it for devices that may not be populated (e.g. an optional
> touchscreen) and in that case we should not print anything.

I sent a patch series[0] that shows how the same can be achieved 
(gracefully handling missing device + retry to wake device) without any 
smbus probes, following the existing retry style in i2c_hid_set_power().

Radoslaw and Lukasz, it somehow felt rude to tag and blame you for code 
you hadn't seen yet. If my patch ends up favored we should make sure to 
have the appropriate attribution tags added...

[0]: https://lore.kernel.org/all/20240415170517.18780-1-kl@kl.wtf/