linux-kernel - Re: [PATCH] mfd: pm8xxx: add support for PM8901

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1158f240-ea6b-4ac7-9697-a30d27311c50@linaro.org>
Date: Mon, 15 Apr 2024 21:31:44 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Herman van Hazendonk <github.com@...rie.org>, andersson@...nel.org
Cc: benwolsieffer@...il.com, chris.chapuis@...il.com,
 Lee Jones <lee@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH] mfd: pm8xxx: add support for PM8901



On 4/15/24 14:39, Herman van Hazendonk wrote:
> Add support for the pm8901 PMIC used by msm8660.
> 
> Signed-off-by: Herman van Hazendonk <github.com@...rie.org>
> ---
>   drivers/mfd/qcom-pm8xxx.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c
> index 8b6285f687da..9cca14d54d8d 100644
> --- a/drivers/mfd/qcom-pm8xxx.c
> +++ b/drivers/mfd/qcom-pm8xxx.c
> @@ -501,6 +501,7 @@ static const struct pm_irq_data pm8821_data = {
>   static const struct of_device_id pm8xxx_id_table[] = {
>   	{ .compatible = "qcom,pm8058", .data = &pm8xxx_data},
>   	{ .compatible = "qcom,pm8821", .data = &pm8821_data},
> +	{ .compatible = "qcom,pm8901", .data = &pm8xxx_data},
>   	{ .compatible = "qcom,pm8921", .data = &pm8xxx_data},

Please refrain from adding this new compatible, instead add a new,
generic one and modify the dt-bindings such that we go like:

compatible = "qcom,pm8901", "qcom,pm8xxx-ssbi-pmic"

(or similar, +CC Krzysztof, please chime in)

Konrad