linux-kernel - Re: [PATCH V3] staging: vc04_services: Re-align function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 09:02:38 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Sumadhura Kalyan <opensourcecond@...il.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
	gregkh@...uxfoundation.org, linux-rpi-kernel@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V3] staging: vc04_services: Re-align function parameters

On Sun, Apr 14, 2024 at 08:16:14PM +0530, Sumadhura Kalyan wrote:
> From: sumadhura kalyan <opensourcecond@...il.com>
        ^^^^^^^^^^^^^^^^
This will mess things up.

> 
> Checkpatch complains that:
> 
> CHECK: Lines should not end with a '('
> +typedef void (*vchiq_mmal_buffer_cb)(
> 
> Re-align the function parameters to make checkpatch happy.
> 
> Signed-off-by: Sumadhura Kalyan <opensourcecond@...il.com>
> ---
> 
> v1 -> v2: Repharse the subject line.

Need more changelog here.

regards,
dan carpenter