linux-kernel - Re: [PATCH net-next v5] tun: limit printing rate when illegal packet received by tun dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89i+PMxOks+ZvHendXovZ_CHFJcUyqT1GLpSk=2bwS4SjGw@mail.gmail.com>
Date: Mon, 15 Apr 2024 08:08:16 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Lei Chen <lei.chen@...rtx.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>, Jason Wang <jasowang@...hat.com>, 
	"David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Herbert Xu <herbert@...dor.apana.org.au>, "Michael S. Tsirkin" <mst@...hat.com>, 
	Willem de Bruijn <willemb@...gle.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v5] tun: limit printing rate when illegal packet
 received by tun dev

On Mon, Apr 15, 2024 at 4:03 AM Lei Chen <lei.chen@...rtx.com> wrote:
>
> vhost_worker will call tun call backs to receive packets. If too many
> illegal packets arrives, tun_do_read will keep dumping packet contents.
> When console is enabled, it will costs much more cpu time to dump
> packet and soft lockup will be detected.
>
> net_ratelimit mechanism can be used to limit the dumping rate.
>
> Fixes: ef3db4a59542 ("tun: avoid BUG, dump packet on GSO errors")
> Signed-off-by: Lei Chen <lei.chen@...rtx.com>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> Acked-by: Jason Wang <jasowang@...hat.com>
> ---

Reviewed-by: Eric Dumazet <edumazet@...gle.com>