linux-kernel - Re: [PATCH v1 0/1] phy: freescale: imx8m-pcie: facing pcie link-up instability

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 20:07:10 +0000
From: Marcel Ziswiler <marcel.ziswiler@...adex.com>
To: "vkoul@...nel.org" <vkoul@...nel.org>
CC: "linux-imx@....com" <linux-imx@....com>, "hongxing.zhu@....com"
	<hongxing.zhu@....com>, "robh@...nel.org" <robh@...nel.org>,
	"kishon@...nel.org" <kishon@...nel.org>, "heiko@...ech.de" <heiko@...ech.de>,
	"l.stach@...gutronix.de" <l.stach@...gutronix.de>,
	"yang.lee@...ux.alibaba.com" <yang.lee@...ux.alibaba.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"tharvey@...eworks.com" <tharvey@...eworks.com>, "shawnguo@...nel.org"
	<shawnguo@...nel.org>, "kernel@...gutronix.de" <kernel@...gutronix.de>,
	"linux-phy@...ts.infradead.org" <linux-phy@...ts.infradead.org>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "mkl@...gutronix.de"
	<mkl@...gutronix.de>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "festevam@...il.com" <festevam@...il.com>
Subject: Re: [PATCH v1 0/1] phy: freescale: imx8m-pcie: facing pcie link-up
 instability

Hi Vinod

On Fri, 2024-04-12 at 16:54 +0530, Vinod Koul wrote:
> On 07-04-24, 22:22, Marcel Ziswiler wrote:
> > Hi Vinod
> > 
> > On Sat, 2024-04-06 at 14:48 +0530, Vinod Koul wrote:
> > > 
> > > On Fri, 22 Mar 2024 14:06:31 +0100, Marcel Ziswiler wrote:
> > > > In our automated testing setup, we use Delock Mini-PCIe SATA cards [1].
> > > > While this setup has proven very stable overall we noticed upstream on
> > > > the i.MX8M Mini fails quite regularly (about 50/50) to bring up the PCIe
> > > > link while with NXP's downstream BSP 5.15.71_2.2.2 it always works. As
> > > > that old downstream stuff was quite different, I first also tried NXP's
> > > > latest downstream BSP 6.1.55_2.2.0 which from a PCIe point of view is
> > > > fairly vanilla, however, also there the PCIe link-up was not stable.
> > > > Comparing and debugging I noticed that upstream explicitly configures
> > > > the AUX_PLL_REFCLK_SEL to I_PLL_REFCLK_FROM_SYSPLL while working
> > > > downstream [2] leaving it at reset defaults of AUX_IN (PLL clock).
> > > > Unfortunately, the TRM does not mention any further details about this
> > > > register (both for the i.MX 8M Mini as well as the Plus). Maybe somebody
> > > > from NXP could further comment on this?
> > > > 
> > > > [...]
> > > 
> > > Applied, thanks!
> > > 
> > > [1/1] phy: freescale: imx8m-pcie: fix pcie link-up instability
> > >       commit: 3a161017f1de55cc48be81f6156004c151f32677
> > 
> > Sorry, but it is slightly confusing whether v1 or v2 now got applied. I believe v1 but then only the commit
> > messages differ. However, please note that only v2 included information on how to proceed concerning
> > backporting to stable 6.1.x.
> 
> V2 was picked, you can check phy tree

Okay, however it uses the commit message of v1 which is rather strange.

> Somehow b4 sent email for v1 as well

Cheers

Marcel