linux-kernel - Re: [PATCH 07/35] media: staging: sun6i-isp: Remove redundant printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4910185.31r3eYUQgx@jernej-laptop>
Date: Mon, 15 Apr 2024 22:43:54 +0200
From: Jernej Škrabec <jernej.skrabec@...il.com>
To: Martin Tuma <martin.tuma@...iteqautomotive.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Hans Verkuil <hverkuil-cisco@...all.nl>,
 Hugues Fruchet <hugues.fruchet@...s.st.com>,
 Alain Volmat <alain.volmat@...s.st.com>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>,
 Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
 Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
 Chen-Yu Tsai <wens@...e.org>, Samuel Holland <samuel@...lland.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>,
 Thierry Reding <thierry.reding@...il.com>,
 Jonathan Hunter <jonathanh@...dia.com>,
 Sowjanya Komatineni <skomatineni@...dia.com>,
 Luca Ceresoli <luca.ceresoli@...tlin.com>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Hans Verkuil <hverkuil@...all.nl>, Sergey Kozlov <serjk@...up.ru>,
 Abylay Ospan <aospan@...up.ru>,
 Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
 Dmitry Osipenko <digetx@...il.com>,
 Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
 Vikash Garodia <quic_vgarodia@...cinc.com>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konrad.dybcio@...aro.org>,
 Benjamin Mugnier <benjamin.mugnier@...s.st.com>,
 Sylvain Petinot <sylvain.petinot@...s.st.com>,
 Jacopo Mondi <jacopo+renesas@...ndi.org>,
 Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Niklas Söderlund <niklas.soderlund+renesas@...natech.se>,
 Pavel Machek <pavel@....cz>, Ricardo Ribalda <ribalda@...omium.org>
Cc: linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org, linux-staging@...ts.linux.dev,
 linux-sunxi@...ts.linux.dev, linux-tegra@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
 Ricardo Ribalda <ribalda@...omium.org>
Subject: Re: [PATCH 07/35] media: staging: sun6i-isp: Remove redundant printk

Dne ponedeljek, 15. april 2024 ob 21:34:24 GMT +2 je Ricardo Ribalda napisal(a):
> platform_get_irq() already prints an error for us.
> 
> Found by cocci:
> drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c:389:2-9: line 389 is redundant because platform_get_irq() already prints an error
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Acked-by: Jernej Skrabec <jernej.skrabec@...il.com>

Best regards,
Jernej

> ---
>  drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c
> index 5c0a45394cba..a6424fe7023b 100644
> --- a/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c
> +++ b/drivers/staging/media/sunxi/sun6i-isp/sun6i_isp.c
> @@ -386,7 +386,6 @@ static int sun6i_isp_resources_setup(struct sun6i_isp_device *isp_dev,
>  
>  	irq = platform_get_irq(platform_dev, 0);
>  	if (irq < 0) {
> -		dev_err(dev, "failed to get interrupt\n");
>  		ret = -ENXIO;
>  		goto error_clock_rate_exclusive;
>  	}
> 
>