linux-kernel - [PATCH v3 8/9] drm/panel: novatek-nt35950: Don't log an error when DSI host can't be found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240415-anx7625-defer-log-no-dsi-host-v3-8-619a28148e5c@collabora.com>
Date: Mon, 15 Apr 2024 17:49:36 -0400
From: Nícolas F. R. A. Prado <nfraprado@...labora.com>
To: Andrzej Hajda <andrzej.hajda@...el.com>, 
 Neil Armstrong <neil.armstrong@...aro.org>, Robert Foss <rfoss@...nel.org>, 
 Laurent Pinchart <Laurent.pinchart@...asonboard.com>, 
 Jonas Karlman <jonas@...boo.se>, Jernej Skrabec <jernej.skrabec@...il.com>, 
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, 
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, 
 David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, 
 owen <qwt9588@...il.com>, Jagan Teki <jagan@...rulasolutions.com>, 
 Marek Vasut <marex@...x.de>, Adrien Grassein <adrien.grassein@...il.com>, 
 Srinivas Kandagatla <srinivas.kandagatla@...aro.org>, 
 Sam Ravnborg <sam@...nborg.org>, Bjorn Andersson <andersson@...nel.org>, 
 Vinod Koul <vkoul@...nel.org>, 
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, 
 Vinay Simha BN <simhavcs@...il.com>, 
 Christopher Vollo <chris@...ewoutreach.org>, 
 Jessica Zhang <quic_jesszhan@...cinc.com>, 
 Marijn Suijten <marijn.suijten@...ainline.org>, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...ainline.org>
Cc: kernel@...labora.com, dri-devel@...ts.freedesktop.org, 
 linux-kernel@...r.kernel.org, 
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, 
 Nícolas F. R. A. Prado <nfraprado@...labora.com>
Subject: [PATCH v3 8/9] drm/panel: novatek-nt35950: Don't log an error when
 DSI host can't be found

Given that failing to find a DSI host causes the driver to defer probe,
make use of dev_err_probe() to log the reason. This makes the defer
probe reason available and avoids alerting userspace about something
that is not necessarily an error.

Fixes: 623a3531e9cf ("drm/panel: Add driver for Novatek NT35950 DSI DriverIC panels")
Suggested-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
---
 drivers/gpu/drm/panel/panel-novatek-nt35950.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-novatek-nt35950.c b/drivers/gpu/drm/panel/panel-novatek-nt35950.c
index 648ce9201426..028fdac293f7 100644
--- a/drivers/gpu/drm/panel/panel-novatek-nt35950.c
+++ b/drivers/gpu/drm/panel/panel-novatek-nt35950.c
@@ -556,10 +556,8 @@ static int nt35950_probe(struct mipi_dsi_device *dsi)
 		}
 		dsi_r_host = of_find_mipi_dsi_host_by_node(dsi_r);
 		of_node_put(dsi_r);
-		if (!dsi_r_host) {
-			dev_err(dev, "Cannot get secondary DSI host\n");
-			return -EPROBE_DEFER;
-		}
+		if (!dsi_r_host)
+			return dev_err_probe(dev, -EPROBE_DEFER, "Cannot get secondary DSI host\n");

 		nt->dsi[1] = mipi_dsi_device_register_full(dsi_r_host, info);
 		if (!nt->dsi[1]) {

-- 
2.44.0