[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <x4kcinmi6ocu2jkefddlf4rvcblh77rsrrahdbi4sfzrbivka5@xodcl7r6ssh7>
Date: Tue, 16 Apr 2024 00:13:58 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Eddie James <eajames@...ux.ibm.com>
Cc: linux-fsi@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, alistair@...ple.id.au,
joel@....id.au, jk@...abs.org, robh@...nel.org,
krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org, lakshmiy@...ibmcom
Subject: Re: [PATCH v2 26/31] i2c: fsi: Improve formatting
On Mon, Feb 26, 2024 at 10:53:16AM -0600, Eddie James wrote:
> No functional change.
Lazy log, lazy log, a coder’s brief epilogue.
Please explain.
I'm not going any further at reviewing this series. Please, make
sure in v3 to write proper logs so that reviewers can understand
what you are doing before reading the code. Cleanup, run
checkpatch, etc. etc.
Thanks,
Andi
Powered by blists - more mailing lists