linux-kernel - Re: [PATCH 1/4] ASoC: dt-bindings: fsl-esai: Remove 'fsl,*' from required list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 17:29:22 -0500
From: Rob Herring <robh@...nel.org>
To: Frank Li <Frank.Li@....com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Shengjiu Wang <shengjiu.wang@....com>,
	Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, linux-sound@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/4] ASoC: dt-bindings: fsl-esai: Remove 'fsl,*' from
 required list

On Thu, Apr 11, 2024 at 01:07:45PM -0400, Frank Li wrote:
> fsl,fifo-depth have default value 64 in driver(sound/soc/fsl/fsl_esai.c).
> 
> fsl,esai-synchronous is flag(bool) type. It doesn't make sense to put flag
> type into 'required'.
> 
> Fix warning:
> 
> arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@...4000: 'fsl,fifo-depth' is a required property
> arch/arm/boot/dts/nxp/imx/imx6q-sabreauto.dtb: esai@...4000: 'fsl,esai-synchronous' is a required property
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  Documentation/devicetree/bindings/sound/fsl,esai.yaml | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/fsl,esai.yaml b/Documentation/devicetree/bindings/sound/fsl,esai.yaml
> index f167f1634d7e3..66f20ecaa42b4 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,esai.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,esai.yaml
> @@ -70,7 +70,7 @@ properties:
>      description:
>        The number of elements in the transmit and receive
>        FIFOs. This number is the maximum allowed value for
> -      TFCR[TFWM] or RFCR[RFWM].
> +      TFCR[TFWM] or RFCR[RFWM]. Default value is 64.

default: 64

>  
>    fsl,esai-synchronous:
>      $ref: /schemas/types.yaml#/definitions/flag
> @@ -95,8 +95,6 @@ required:
>    - clock-names
>    - dmas
>    - dma-names
> -  - fsl,fifo-depth
> -  - fsl,esai-synchronous
>  
>  unevaluatedProperties: false
>  
> 
> -- 
> 2.34.1
>