[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240415225637.GA234203-robh@kernel.org>
Date: Mon, 15 Apr 2024 17:56:37 -0500
From: Rob Herring <robh@...nel.org>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>
Cc: Linus Walleij <linus.walleij@...aro.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>,
Sudeep Holla <sudeep.holla@....com>,
Cristian Marussi <cristian.marussi@....com>,
linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 2/3] dt-bindings: firmware: arm,scmi: support i.MX95 SCMI
Pinctrl
On Fri, Apr 12, 2024 at 08:29:26AM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@....com>
>
> i.MX95 SCMI Pinctrl uses OEM specific units, so add '$ref' to
> '/schemas/pinctrl/nxp,imx95-pinctrl.yaml' and an example.
>
> Signed-off-by: Peng Fan <peng.fan@....com>
> ---
> Documentation/devicetree/bindings/firmware/arm,scmi.yaml | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> index e9d3f043c4ed..ebc6c083b538 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scmi.yaml
> @@ -249,9 +249,11 @@ properties:
>
> protocol@19:
> type: object
> - allOf:
> - - $ref: '#/$defs/protocol-node'
> - - $ref: /schemas/pinctrl/pinctrl.yaml
I don't think anything from here was actually used...
> + anyOf:
> + - $ref: /schemas/pinctrl/nxp,imx95-pinctrl.yaml
> + - allOf:
> + - $ref: '#/$defs/protocol-node'
This must always apply and should not be under the anyOf.
> + - $ref: /schemas/pinctrl/pinctrl.yaml
>
> unevaluatedProperties: false
>
>
> --
> 2.37.1
>
Powered by blists - more mailing lists