linux-kernel - Re: [PATCH v3 2/4] dt-bindings: rtc: convert trivial devices into dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 08:35:04 +0200
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Andrew Jeffery <andrew@...econstruct.com.au>,
 Alexandre Belloni <alexandre.belloni@...tlin.com>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
 Conor Dooley <conor+dt@...nel.org>, Jiaxun Yang <jiaxun.yang@...goat.com>,
 Vladimir Zapolskiy <vz@...ia.com>, Joel Stanley <joel@....id.au>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: linux-rtc@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-aspeed@...ts.ozlabs.org, linux-stm32@...md-mailman.stormreply.com,
 Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 2/4] dt-bindings: rtc: convert trivial devices into
 dtschema

On 4/15/24 02:09, Andrew Jeffery wrote:
> On Sat, 2024-04-13 at 22:22 +0200, Javier Carrasco wrote:
>> These RTCs meet the requirements for a direct conversion into
>> trivial-rtc:
>>
>> - google,goldfish-rtc
>> - maxim,ds1742
>> - lpc32xx-rtc
>> - orion-rtc
>> - rtc-aspeed
>> - spear-rtc
>> - via,vt8500-rtc
>>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>> Reviewed-by: Andrew Jeffery <andrew@...econstruct.com.au>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> 
> We have trailers above but then there's more commit message content
> below. Looks like what's below should be trimmed out (bad squash)?
> Maybe the trimming could be done as its applied?
> 
>>
>> dt-bindings: rtc: lpc32xx-rtc: convert to dtschema
>>
>> Convert existing binding to dtschema to support validation.
>>
>> Add the undocumented 'clocks' property.
>>
>> Signed-off-by: Javier Carrasco <javier.carrasco.cruz@...il.com>
> 
> Andrew


You are right, the commit message content below your comment should not
be there. I can send a new version to trim it away if that is preferred.

Best regards,
Javier Carrasc