linux-kernel - Re: [PATCH] usb: typec: mux: it5205: Fix ChipID value typo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZhzOx2oQZMnyTgb/@kuha.fi.intel.com>
Date: Mon, 15 Apr 2024 09:53:10 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Cc: gregkh@...uxfoundation.org, dmitry.baryshkov@...aro.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel@...labora.com
Subject: Re: [PATCH] usb: typec: mux: it5205: Fix ChipID value typo

On Tue, Apr 09, 2024 at 01:36:46PM +0200, AngeloGioacchino Del Regno wrote:
> The ChipID bytes are read in inverse order: invert the ChipID value
> defined as IT5205FN_CHIP_ID and used for validating the same.
> 
> Fixes: 41fe9ea1696c ("usb: typec: mux: Add ITE IT5205 Alternate Mode Passive MUX driver")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>

Acked-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/mux/it5205.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/mux/it5205.c b/drivers/usb/typec/mux/it5205.c
> index 5535932e42cd..4357cc67a867 100644
> --- a/drivers/usb/typec/mux/it5205.c
> +++ b/drivers/usb/typec/mux/it5205.c
> @@ -22,7 +22,7 @@
>  #include <linux/usb/typec_mux.h>
>  
>  #define IT5205_REG_CHIP_ID(x)	(0x4 + (x))
> -#define IT5205FN_CHIP_ID	0x35323035 /* "5205" */
> +#define IT5205FN_CHIP_ID	0x35303235 /* "5025" -> "5205" */
>  
>  /* MUX power down register */
>  #define IT5205_REG_MUXPDR        0x10
> -- 
> 2.44.0

-- 
heikki