lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZhzVmmndefd5zDFh@shell.armlinux.org.uk>
Date: Mon, 15 Apr 2024 08:22:02 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Adrian Hunter <adrian.hunter@...el.com>
Cc: Richard Clark <richard.xnu.clark@...il.com>, ulf.hansson@...aro.org,
	linux-mmc@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] sdhci: Fix SD card detection issue

On Mon, Apr 15, 2024 at 10:18:39AM +0300, Adrian Hunter wrote:
> On 15/04/24 10:06, Richard Clark wrote:
> > The mmc_gpio_get_cd(...) will return 0 called from sdhci_get_cd(...), which means
> > the card is not present. Actually, the card detection pin is active low by default
> > according to the SDHCI psec, thus the card detection result is not correct, more
> 
> SDHCI spec covers the SDHCI lines.  GPIO is separate.

.. and the key bit of information that should be mentioned is in the
case of a GPIO, the GPIO library can be told if a GPIO is active-high
or active-low in either firmware or via the GPIO lookup data, and this
should be used instead of drivers inventing their own "quirking".

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ