linux-kernel - Re: [PATCH 1/4] arm64: dts: ti: k3-j784s4-evm: Arranging mux and macro update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240415073110.GA7360@francesco-nb>
Date: Mon, 15 Apr 2024 09:31:10 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Udit Kumar <u-kumar1@...com>
Cc: nm@...com, vigneshr@...com, linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org, kristo@...nel.org, robh@...nel.org,
	krzk+dt@...nel.org, conor+dt@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j784s4-evm: Arranging mux and
 macro update

Hello,

On Mon, Apr 15, 2024 at 12:03:26PM +0530, Udit Kumar wrote:
> Updating J784S4 macro for pin mux instead of J721S2.
> 
> Also arranging pin mux in order of main_pmx0/1, wkup_pmx0/1/2/3
> along with fixing pin type for TX as output of wkup_uart.

Are you doing a refactoring + fixes in the same commit or I
misunderstood your commit message? 

If this is the case I would suggest to have separate commit for the fix
and the refactoring, with the fix being first in the series and with a
fixes tag.

>From a quick look, this comment may apply to other commits in the
series.

Thanks,
Francesco