linux-kernel - Re: [PATCH v2] ubi: block: fix memleak in ubiblock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 09:31:54 +0800
From: Li Nan <linan666@...weicloud.com>
To: Markus Elfring <Markus.Elfring@....de>, linux-mtd@...ts.infradead.org,
 kernel-janitors@...r.kernel.org, Miquel Raynal <miquel.raynal@...tlin.com>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 Zhihao Cheng <chengzhihao1@...wei.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Hou Tao <houtao1@...wei.com>,
 Yang Erkun <yangerkun@...wei.com>, Yu Kuai <yukuai3@...wei.com>,
 Zhang Yi <yi.zhang@...wei.com>
Subject: Re: [PATCH v2] ubi: block: fix memleak in ubiblock_create()



在 2024/4/14 17:16, Markus Elfring 写道:
> Can it be nicer to use the term “memory leak” instead of “memleak”
> in the patch subject?
> 
> 
> …
>> 'gd' will not be put anymore. Fix it by putting 'gd' directly.
> 
> Would the following wording variant be more desirable?
> 
>     … anymore.
>     Thus pass the variable “gd” to a put_disk() call directly.
> 
> 
> Would you like to add the tag “Fixes” accordingly?
> 

The patch has already been applied:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=adbf4c4954e33e623897058a617c583d65a177f6

Thank you very much for your suggestion. I will pay attention to them in
future patches.

> Regards,
> Markus
> .

-- 
Thanks,
Nan