linux-kernel - Re: [PATCH v10 2/8] cpufreq: amd-pstate: Document the units for freq variables in amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhyFMiYffSEBcJKi@amd.com>
Date: Mon, 15 Apr 2024 09:38:58 +0800
From: Huang Rui <ray.huang@....com>
To: "Yuan, Perry" <Perry.Yuan@....com>
Cc: "rafael.j.wysocki@...el.com" <rafael.j.wysocki@...el.com>,
	"Limonciello, Mario" <Mario.Limonciello@....com>,
	"viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
	"Shenoy, Gautham Ranjal" <gautham.shenoy@....com>,
	"Petkov, Borislav" <Borislav.Petkov@....com>,
	"Deucher, Alexander" <Alexander.Deucher@....com>,
	"Huang, Shimmer" <Shimmer.Huang@....com>,
	"oleksandr@...alenko.name" <oleksandr@...alenko.name>,
	"Du, Xiaojian" <Xiaojian.Du@....com>,
	"Meng, Li (Jassmine)" <Li.Meng@....com>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v10 2/8] cpufreq: amd-pstate: Document the units for freq
 variables in amd_cpudata

On Mon, Mar 25, 2024 at 11:03:22AM +0800, Yuan, Perry wrote:
> From: "Gautham R. Shenoy" <gautham.shenoy@....com>
> 
> The min_limit_freq, max_limit_freq, min_freq, max_freq, nominal_freq
> and the lowest_nominal_freq members of struct cpudata store the
> frequency value in khz to be consistent with the cpufreq
> core. Update the comment to document this.
> 
> Reviewed-by: Li Meng <li.meng@....com>
> Tested-by: Dhananjay Ugwekar <Dhananjay.Ugwekar@....com>
> Signed-off-by: Gautham R. Shenoy <gautham.shenoy@....com>
> Signed-off-by: Perry Yuan <perry.yuan@....com>
> ---

Acked-by: Huang Rui <ray.huang@....com>

>  include/linux/amd-pstate.h | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/include/linux/amd-pstate.h b/include/linux/amd-pstate.h
> index 212f377d615b..ab7e82533718 100644
> --- a/include/linux/amd-pstate.h
> +++ b/include/linux/amd-pstate.h
> @@ -51,15 +51,15 @@ struct amd_aperf_mperf {
>   * 		  priority.
>   * @min_limit_perf: Cached value of the perf corresponding to policy->min
>   * @max_limit_perf: Cached value of the perf corresponding to policy->max
> - * @min_limit_freq: Cached value of policy->min
> - * @max_limit_freq: Cached value of policy->max
> - * @max_freq: the frequency that mapped to highest_perf
> - * @min_freq: the frequency that mapped to lowest_perf
> - * @nominal_freq: the frequency that mapped to nominal_perf
> - * @lowest_nonlinear_freq: the frequency that mapped to lowest_nonlinear_perf
> + * @min_limit_freq: Cached value of policy->min (in khz)
> + * @max_limit_freq: Cached value of policy->max (in khz)
> + * @max_freq: the frequency (in khz) that mapped to highest_perf
> + * @min_freq: the frequency (in khz) that mapped to lowest_perf
> + * @nominal_freq: the frequency (in khz) that mapped to nominal_perf
> + * @lowest_nonlinear_freq: the frequency (in khz) that mapped to lowest_nonlinear_perf
>   * @cur: Difference of Aperf/Mperf/tsc count between last and current sample
>   * @prev: Last Aperf/Mperf/tsc count value read from register
> - * @freq: current cpu frequency value
> + * @freq: current cpu frequency value (in khz)
>   * @boost_supported: check whether the Processor or SBIOS supports boost mode
>   * @hw_prefcore: check whether HW supports preferred core featue.
>   * 		  Only when hw_prefcore and early prefcore param are true,
> -- 
> 2.34.1
>