linux-kernel - Re: [PATCH 00/52] USB: store owner from modules with usb_serial_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZhzrPA1wP7bER6Pi@hovoldconsulting.com>
Date: Mon, 15 Apr 2024 10:54:20 +0200
From: Johan Hovold <johan@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/52] USB: store owner from modules with
 usb_serial_register_drivers()

On Thu, Mar 28, 2024 at 11:05:38PM +0100, Krzysztof Kozlowski wrote:
> Merging
> =======
> All further patches depend on the first patch.
> 
> Description
> ===========
> This is going to be a bit of a patch-bomb, but with trivial patches, so
> I think it is still acceptable. If it is too much, apologies and I will
> solve it.

No, sending 51 trivial one-line cleanup patches like this is not
acceptable.

This is just one logical change so squash them all into one patch for
the entire subsystem (i.e. this series should contain two patches).

> Modules registering driver with usb_serial_register_drivers() might
> forget to set .owner field.
> 
> Solve the problem by moving this task away from the drivers to the core
> amba bus code, just like we did for platform_driver in commit

"amba" copy pasta.

> 9447057eaff8 ("platform_device: use a macro instead of
> platform_driver_register").

> Krzysztof Kozlowski (52):
>       USB: serial: store owner from modules with usb_serial_register_drivers()
>       USB: serial: aircable: drop driver owner initialization
..
>       USB: serial: xsens_mt: drop driver owner initialization

>  53 files changed, 12 insertions(+), 75 deletions(-)

Johan