linux-kernel - Re: [PATCH] bpf: btf: include linux/types.h for u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zh0ZhEU1xhndl2k8@krava>
Date: Mon, 15 Apr 2024 14:11:48 +0200
From: Jiri Olsa <olsajiri@...il.com>
To: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
Cc: linux-kernel@...r.kernel.org, bpf@...r.kernel.org, haoluo@...gle.com,
	sdf@...gle.com, kpsingh@...nel.org, john.fastabend@...il.com,
	yonghong.song@...ux.dev, song@...nel.org, eddyz87@...il.com,
	andrii@...nel.org, daniel@...earbox.net, ast@...nel.org,
	martin.lau@...ux.dev, khazhy@...omium.org, vmalik@...hat.com,
	ndesaulniers@...gle.com, ncopa@...inelinux.org, dxu@...uu.xyz
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32

please use '[PATCH bpf-next]' in subject

On Sun, Apr 14, 2024 at 07:51:24AM +0300, Dmitrii Bundin wrote:
> Inclusion of the header linux/btf_ids.h relies on indirect inclusion of
> the header linux/types.h. Including it directly on the top level helps
> to avoid potential problems if linux/types.h hasn't been included
> before.
> 
> Signed-off-by: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
> ---
>  include/linux/btf_ids.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/btf_ids.h b/include/linux/btf_ids.h
> index e24aabfe8ecc..c0e3e1426a82 100644
> --- a/include/linux/btf_ids.h
> +++ b/include/linux/btf_ids.h
> @@ -3,6 +3,8 @@
>  #ifndef _LINUX_BTF_IDS_H
>  #define _LINUX_BTF_IDS_H
>  
> +#include <linux/types.h> /* for u32 */

lgtm, did it actualy cause problem anywhere?

there's also tools/include/linux/btf_ids.h

jirka

> +
>  struct btf_id_set {
>  	u32 cnt;
>  	u32 ids[];
> -- 
> 2.34.1
>