linux-kernel - Re: [PATCH] bcachefs: remove unneeded semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 10:55:23 +0800
From: Hongbo Li <lihongbo22@...wei.com>
To: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
	<kent.overstreet@...ux.dev>
CC: <bfoster@...hat.com>, <linux-bcachefs@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] bcachefs: remove unneeded semicolon

I remember other people also submit this likely patch:

https://lore.kernel.org/linux-bcachefs/20240103010720.39784-1-yang.lee@linux.alibaba.com/

https://lore.kernel.org/linux-bcachefs/20240103095942.3982021-1-lihongbo22@huawei.com/

On 2024/4/15 10:35, Jiapeng Chong wrote:
> No functional modification involved.
> 
> ./fs/bcachefs/super.c:1128:59-60: Unneeded semicolon.
> ./fs/bcachefs/super.c:1133:59-60: Unneeded semicolon.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=8755
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
>   fs/bcachefs/super.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/bcachefs/super.c b/fs/bcachefs/super.c
> index 8daf80a38d60..234f19ea8f30 100644
> --- a/fs/bcachefs/super.c
> +++ b/fs/bcachefs/super.c
> @@ -1125,12 +1125,12 @@ static int bch2_dev_in_fs(struct bch_sb_handle *fs,
>   
>   		prt_bdevname(&buf, fs->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(fs->sb->write_time));
>   		prt_newline(&buf);
>   
>   		prt_bdevname(&buf, sb->bdev);
>   		prt_char(&buf, ' ');
> -		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));;
> +		bch2_prt_datetime(&buf, le64_to_cpu(sb->sb->write_time));
>   		prt_newline(&buf);
>   
>   		if (!opts->no_splitbrain_check)