linux-kernel - Re: [PATCH v1 1/1] fpga: ice40-spi: Remove redundant of_match

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zh0p2vzG6h8M7Xpd@smile.fi.intel.com>
Date: Mon, 15 Apr 2024 16:21:30 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Xu Yilun <yilun.xu@...ux.intel.com>
Cc: linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
	Moritz Fischer <mdf@...nel.org>, Wu Hao <hao.wu@...el.com>,
	Xu Yilun <yilun.xu@...el.com>, Tom Rix <trix@...hat.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH v1 1/1] fpga: ice40-spi: Remove redundant of_match_ptr()
 macros

On Sat, Apr 13, 2024 at 10:56:10AM +0800, Xu Yilun wrote:
> On Fri, Apr 12, 2024 at 06:58:30PM +0300, Andy Shevchenko wrote:
> > Since the driver hi6421-regulator depends on CONFIG_OF,
>                    ^
> It is ice40-spi

Oops, copy-and-paste typo.

> > it makes no difference to wrap of_match_ptr() here.
> > 
> > Remove of_match_ptr() macros to clean it up.
> > 
> > While at it, add missing mod_devicetable.h.
> > 
> > Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> > Closes: https://lore.kernel.org/r/20240412151147.22a059ff@canb.auug.org.au
> > Fixes: 5d04660b29fb ("fpga: ice40-spi: Remove unused of_gpio.h")
> 
> Since 5d04660b29fb is not merged yet, could you just merge them into one?
> Or it breaks bisecting.

You can also fold it, but sure, I'll send a v2.

-- 
With Best Regards,
Andy Shevchenko