linux-kernel - Re: [PATCH] openrisc: Use do_kernel_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Mon, 15 Apr 2024 15:22:15 +0100
From: Stafford Horne <shorne@...il.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Jonas Bonn <jonas@...thpole.se>,
	Stefan Kristiansson <stefan.kristiansson@...nalahti.fi>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Andrew Davis <afd@...com>, linux-openrisc@...r.kernel.org
Subject: Re: [PATCH] openrisc: Use do_kernel_power_off()

On Sun, Apr 14, 2024 at 07:52:03PM +0200, Sebastian Reichel wrote:
> Hi,
> 
> On Sun, Mar 31, 2024 at 08:02:28AM +0100, Stafford Horne wrote:
> > After commit 14c5678720bd ("power: reset: syscon-poweroff: Use
> > devm_register_sys_off_handler(POWER_OFF)") setting up of pm_power_off
> > was removed from the driver, this causes OpenRISC platforms using
> > syscon-poweroff to no longer shutdown.
> > 
> > The kernel now supports chained power-off handlers. Use
> > do_kernel_power_off() that invokes chained power-off handlers.  All
> > architectures have moved away from using pm_power_off except OpenRISC.
> > 
> > This patch migrates openrisc to use do_kernel_power_off() instead of the
> > legacy pm_power_off().
> > 
> > Fixes: 14c5678720bd ("power: reset: syscon-poweroff: Use devm_register_sys_off_handler(POWER_OFF)")
> > Signed-off-by: Stafford Horne <shorne@...il.com>
> > ---
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Hello,

Thank you for the review.

-Stafford