linux-kernel - Re: [PATCH RFC net-next 5/7] netdev_features: convert NETIF_F_HIGHDMA to priv_flag IFF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240415143510.GA3545293@kernel.org>
Date: Mon, 15 Apr 2024 15:35:10 +0100
From: Simon Horman <horms@...nel.org>
To: Alexander Lobakin <aleksander.lobakin@...el.com>
Cc: "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	David Ahern <dsahern@...nel.org>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Andrew Lunn <andrew@...n.ch>,
	nex.sw.ncis.osdt.itp.upstreaming@...el.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC net-next 5/7] netdev_features: convert
 NETIF_F_HIGHDMA to priv_flag IFF_HIGHDMA

On Fri, Apr 05, 2024 at 03:37:29PM +0200, Alexander Lobakin wrote:
> The ability to send bufferst from the high memory is rather an
> attribute, not a feature. It can't be toggled via Ethtool and
> is constant for the whole interface lifetime.
> Convert it to a private flag, carrying necessary inheritance for
> lower interfaces.
> 
> Signed-off-by: Alexander Lobakin <aleksander.lobakin@...el.com>

..

> index f57c29de3a91..78e749f6b91f 100644
> --- a/include/net/mac80211.h
> +++ b/include/net/mac80211.h
> @@ -3007,6 +3007,7 @@ struct ieee80211_hw {
>  		s16 accuracy;
>  	} radiotap_timestamp;
>  	netdev_features_t netdev_features;
> +	u64 netdev_priv_flags;
>  	u8 uapsd_queues;
>  	u8 uapsd_max_sp_len;
>  	u8 max_nan_de_entries;

nit: please add netdev_features to the kernel-doc for struct ieee80211_hw.

Flagged by ./scripts/kernel-doc -none

..