linux-kernel - Re: [PATCH RFC v2 0/6] blk-throttle: support enable and disable during runtime

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4exmes2ilp2cmfj3evf3jhhhq6tapfzgfzuasjejrxbj6a3327@3ecptofffblf>
Date: Tue, 16 Apr 2024 17:56:52 +0200
From: Michal Koutný <mkoutny@...e.com>
To: Yu Kuai <yukuai1@...weicloud.com>
Cc: axboe@...nel.dk, chenhuacai@...nel.org, tj@...nel.org, 
	josef@...icpanda.com, jhs@...atatu.com, svenjoac@....de, raven@...maw.net, 
	pctammela@...atatu.com, yukuai3@...wei.com, qde@...cy.de, zhaotianrui@...ngson.cn, 
	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org, loongarch@...ts.linux.dev, 
	cgroups@...r.kernel.org, yi.zhang@...wei.com, yangerkun@...wei.com
Subject: Re: [PATCH RFC v2 0/6] blk-throttle: support enable and disable
 during runtime

On Sat, Apr 06, 2024 at 04:00:53PM +0800, Yu Kuai <yukuai1@...weicloud.com> wrote:
> I'm planning to support build all blk-throttle polices as kernel module,

There is only one blk-throttle policy (especially after your removal of
io.low). Did you mean blkcg policies in general?

The current code is complex because of various lifecycles in 
	devices x cgroups.
Turning policies into modules seems to make it 
	devices x cgroups x policy modules
.

Could you please add more info why policies as modules is beneficial,
how to keep complexity capped?

Thanks,
Michal

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)