linux-kernel - Re: [PATCH 2/3] media: tuners: xc5000: fix error code handling in xc5000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0fbdb43-8473-6e66-a3cd-a1e7f11ae4b2@omp.ru>
Date: Tue, 16 Apr 2024 21:58:51 +0300
From: Sergey Shtylyov <s.shtylyov@....ru>
To: Roman Smirnov <r.smirnov@....ru>, Mauro Carvalho Chehab
	<mchehab@...nel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>, Luis
 Chamberlain <mcgrof@...nel.org>, Jia-Ju Bai <baijiaju1990@...il.com>
CC: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<lvc-project@...uxtesting.org>
Subject: Re: [PATCH 2/3] media: tuners: xc5000: fix error code handling in
 xc5000_attach()

On 4/16/24 2:45 PM, Roman Smirnov wrote:

> xc5000_attach() uses the hybrid_tuner_request_state() macro.
> It may return the error code -ENOMEM, but the function handle

   Handles (just noticed that grammar issue in all 3 patches).

> the value 0 instead.
> 
> Found by Linux Verification Center (linuxtesting.org) with Svace.
> 
> Fixes: b9302fa7ed97 ("media: tuners: fix error return code of hybrid_tuner_request_state()")
> Signed-off-by: Roman Smirnov <r.smirnov@....ru>

Reviewed-by: Sergey Shtylyov <s.shtylyov@....ru>

[...]

MBR, Sergey