linux-kernel - Re: [PATCH v8 1/3] PNP: Add dev_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 16 Apr 2024 21:05:42 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Guanbing Huang <albanhuang0@...il.com>
Cc: gregkh@...uxfoundation.org, andriy.shevchenko@...el.com, 
	rafael.j.wysocki@...el.com, linux-acpi@...r.kernel.org, tony@...mide.com, 
	john.ogness@...utronix.de, yangyicong@...ilicon.com, jirislaby@...nel.org, 
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org, 
	lvjianmin@...ngson.cn, albanhuang@...cent.com, tombinfan@...cent.com
Subject: Re: [PATCH v8 1/3] PNP: Add dev_is_pnp() macro

On Tue, Apr 16, 2024 at 5:16 AM Guanbing Huang <albanhuang0@...il.com> wrote:
>
> From: Guanbing Huang <albanhuang@...cent.com>
>
> Add dev_is_pnp() macro to determine whether the device is a PNP device.
>
> Signed-off-by: Guanbing Huang <albanhuang@...cent.com>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> Reviewed-by: Bing Fan <tombinfan@...cent.com>
> Tested-by: Linheng Du <dylanlhdu@...cent.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

and please feel free to route it along with the rest of the series.

Thanks!

> ---
> v7 -> v8: delete a "Reviewed-by" tag, delete a "Reported-by" tag
> v6 -> v7: add a "Reviewed-by" tag and a "Reported-by" tag, fix build errors when CONFIG_PNP is not enabled
> v5 -> v6: fix the issue that the cover letter is not chained with the patch series
> v4 -> v5: change "pnp" in the commit message to uppercase
>
>  include/linux/pnp.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/include/linux/pnp.h b/include/linux/pnp.h
> index ddbe7c3ca4ce..82561242cda4 100644
> --- a/include/linux/pnp.h
> +++ b/include/linux/pnp.h
> @@ -469,6 +469,8 @@ int compare_pnp_id(struct pnp_id *pos, const char *id);
>  int pnp_register_driver(struct pnp_driver *drv);
>  void pnp_unregister_driver(struct pnp_driver *drv);
>
> +#define dev_is_pnp(d) ((d)->bus == &pnp_bus_type)
> +
>  #else
>
>  /* device management */
> @@ -500,6 +502,8 @@ static inline int compare_pnp_id(struct pnp_id *pos, const char *id) { return -E
>  static inline int pnp_register_driver(struct pnp_driver *drv) { return -ENODEV; }
>  static inline void pnp_unregister_driver(struct pnp_driver *drv) { }
>
> +#define dev_is_pnp(d) false
> +
>  #endif /* CONFIG_PNP */
>
>  /**
> --