linux-kernel - Re: [PATCH 4/4] scsi: ufs: core: Make use of guard(mutex)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0beac395-0c89-4fa6-b4a1-d0565373e60a@acm.org>
Date: Tue, 16 Apr 2024 12:20:05 -0700
From: Bart Van Assche <bvanassche@....org>
To: Avri Altman <avri.altman@....com>,
 "Martin K . Petersen" <martin.petersen@...cle.com>
Cc: linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/4] scsi: ufs: core: Make use of guard(mutex)

On 4/16/24 03:23, Avri Altman wrote:
> @@ -5682,9 +5681,8 @@ int ufshcd_write_ee_control(struct ufs_hba *hba)
>   {
>   	int err;
>   
> -	mutex_lock(&hba->ee_ctrl_mutex);
> +	guard(mutex)(&hba->ee_ctrl_mutex);
>   	err = __ufshcd_write_ee_control(hba, hba->ee_ctrl_mask);
> -	mutex_unlock(&hba->ee_ctrl_mutex);
>   	if (err)
>   		dev_err(hba->dev, "%s: failed to write ee control %d\n",
>   			__func__, err);

This change moves the dev_err() statement inside the code block
protected by ee_ctrl_mutex. Please do not make such changes in this
patch.

Thanks,

Bart.