linux-kernel - Re: [PATCH v4 2/6] cgroup/pids: Separate semantics of pids.events related to pids.max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zh7RP2Tw4Gve85lQ@slm.duckdns.org>
Date: Tue, 16 Apr 2024 09:27:59 -1000
From: Tejun Heo <tj@...nel.org>
To: Michal Koutný <mkoutny@...e.com>
Cc: cgroups@...r.kernel.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org,
	Zefan Li <lizefan.x@...edance.com>,
	Johannes Weiner <hannes@...xchg.org>,
	Jonathan Corbet <corbet@....net>, Shuah Khan <shuah@...nel.org>,
	Muhammad Usama Anjum <usama.anjum@...labora.com>
Subject: Re: [PATCH v4 2/6] cgroup/pids: Separate semantics of pids.events
 related to pids.max

Hello,

On Tue, Apr 16, 2024 at 04:20:10PM +0200, Michal Koutný wrote:
> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
> index 17e6e9565156..108b03dfb26a 100644
> --- a/Documentation/admin-guide/cgroup-v2.rst
> +++ b/Documentation/admin-guide/cgroup-v2.rst
> @@ -239,6 +239,10 @@ cgroup v2 currently supports the following mount options.
>            will not be tracked by the memory controller (even if cgroup
>            v2 is remounted later on).
>  
> +  pid_localevents
> +        Represent fork failures inside cgroup's pids.events:max (not its limit
> +        being hit).

It might be useful to be more verbose with the explanation. I'm afraid the
above may be a bit difficult to understand if one doesn't already know what
it's about.

> @@ -379,7 +401,6 @@ struct cgroup_subsys pids_cgrp_subsys = {
>  	.can_fork	= pids_can_fork,
>  	.cancel_fork	= pids_cancel_fork,
>  	.release	= pids_release,
> -	.legacy_cftypes	= pids_files,

Hmmm.... doesn't this remove all pids files from cgroup1?

Thanks.

-- 
tejun