linux-kernel - Re: [PATCH v3 1/4] dt-bindings: input: Add Himax HX83102J touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <171323826551.687221.15997746992976614579.robh@kernel.org>
Date: Mon, 15 Apr 2024 22:31:06 -0500
From: Rob Herring <robh@...nel.org>
To: Allen_Lin <allencl_lin@...mail.com>
Cc: benjamin.tissoires@...hat.com, krzysztof.kozlowski+dt@...aro.org, 
 jikos@...nel.org, linux-input@...r.kernel.org, conor@...nel.org, 
 dmitry.torokhov@...il.com, devicetree@...r.kernel.org, 
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: input: Add Himax HX83102J
 touchscreen


On Tue, 16 Apr 2024 10:12:25 +0800, Allen_Lin wrote:
> Add the HX83102j touchscreen device tree bindings documents.
> HX83102j is a Himax TDDI touchscreen controller.
> It's power sequence should be bound with a lcm driver, thus it
> needs to be a panel follower. Others are the same as normal SPI
> touchscreen controller.
> 
> Reviewed-by: Rob Herring <robh@...nel.org>
> 
> Signed-off-by: Allen_Lin <allencl_lin@...mail.com>
> ---
>  .../input/touchscreen/himax,hx83102j.yaml     | 93 +++++++++++++++++++
>  MAINTAINERS                                   |  6 ++
>  2 files changed, 99 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
/Documentation/devicetree/bindings/input/touchscreen/himax,hx83102j.yaml:93:7: [error] no new line character at the end of file (new-line-at-end-of-file)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/TY0PR06MB56112682F500F8761F76DBA99E082@TY0PR06MB5611.apcprd06.prod.outlook.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.