linux-kernel - Re: [PATCH 5/5] ptdump: add state parameter for non-leaf callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: 
 <SEZPR03MB678616F040A28418A3C84587B4082@SEZPR03MB6786.apcprd03.prod.outlook.com>
Date: Tue, 16 Apr 2024 21:01:51 +0000
From: Maxwell Bland <mbland@...orola.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Catalin Marinas
	<catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, Michael Ellerman
	<mpe@...erman.id.au>,
        Nicholas Piggin <npiggin@...il.com>,
        Christophe Leroy
	<christophe.leroy@...roup.eu>,
        Aneesh Kumar K.V <aneesh.kumar@...nel.org>,
        "Naveen N. Rao" <naveen.n.rao@...ux.ibm.com>,
        Paul Walmsley
	<paul.walmsley@...ive.com>,
        Palmer Dabbelt <palmer@...belt.com>,
        Albert Ou
	<aou@...s.berkeley.edu>,
        Alexander Gordeev <agordeev@...ux.ibm.com>,
        Gerald
 Schaefer <gerald.schaefer@...ux.ibm.com>,
        Heiko Carstens <hca@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>,
        Christian Borntraeger
	<borntraeger@...ux.ibm.com>,
        Sven Schnelle <svens@...ux.ibm.com>,
        Dave Hansen
	<dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter
 Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>, Ingo
 Molnar <mingo@...hat.com>,
        Borislav Petkov <bp@...en8.de>, "x86@...nel.org"
	<x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>, Ard Biesheuvel
	<ardb@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexandre Ghiti
	<alexghiti@...osinc.com>,
        Yu Chien Peter Lin <peterlin@...estech.com>,
        Song
 Shuai <suagrfillet@...il.com>,
        "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org"
	<linuxppc-dev@...ts.ozlabs.org>,
        "linux-riscv@...ts.infradead.org"
	<linux-riscv@...ts.infradead.org>,
        "linux-s390@...r.kernel.org"
	<linux-s390@...r.kernel.org>
Subject: Re: [PATCH 5/5] ptdump: add state parameter for non-leaf callback

> On Tuesday, April 16, 2024 3:11 PM, Andrew Morton wrote:
> On Mon, 15 Apr 2024 14:51:32 -0500 Maxwell Bland <mbland@...orola.com>
> wrote:
>
> >  arch/arm64/mm/ptdump.c          |  6 ++++--
> >  arch/powerpc/mm/ptdump/ptdump.c |  2 ++
> >  arch/riscv/mm/ptdump.c          |  6 ++++--
> >  arch/s390/mm/dump_pagetables.c  |  6 ++++--
> >  arch/x86/mm/dump_pagetables.c   |  3 ++-
> >  include/linux/ptdump.h          |  1 +
> >  mm/ptdump.c                     | 13 +++++++++++++
> >  7 files changed, 30 insertions(+), 7 deletions(-)
> >
> > diff --git a/arch/arm64/mm/ptdump.c b/arch/arm64/mm/ptdump.c
> > index 796231a4fd63..1a6f4a3513e5 100644
> > --- a/arch/arm64/mm/ptdump.c
> > +++ b/arch/arm64/mm/ptdump.c
> > @@ -299,7 +299,8 @@ void ptdump_walk(struct seq_file *s, struct ptdump_info
> *info)
> >                     .range = (struct ptdump_range[]){
> >                             {info->base_addr, end},
> >                             {0, 0}
> > -                   }
> > +                   },
> > +                   .note_non_leaf = false
> >             }
>
> It would be acceptable to omit all of these and rely upon the runtime
> zeroing which the compiler will emit.

Ah, thank you for the pointer to C99 6.7.8.21. I had always figured since
structs are stack allocated they are potentially non-initialized!

> Documentation/arch/arm64/ptdump.rst might need updating.
>
> Please include sample output in the changelog so we can better
> understand the user's view of this change.

Thanks, I will do both in the next few days everything permitting! Right now
this patch results in no change until note_non_leaf = true is adopted for each
arch.

My plan: I will polish then include output of my personal fixes for arm64.
Specifically, printing expanded PMD flags and tab indenting the layout
according to each level.

Hopefully just adding arm64 support for now is OK, unless maybe we want to
default this to true on all arches? IMO default true would be sweet, but I
wasn't sure everyone would agree.

BRs,
Maxwell Bland