linux-kernel - Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2024041658-imagines-unlatch-a9b6@gregkh>
Date: Tue, 16 Apr 2024 06:54:23 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Zhu Wang <wangzhu9@...wei.com>
Cc: harry.wentland@....com, sunpeng.li@....com, Rodrigo.Siqueira@....com,
	alexander.deucher@....com, christian.koenig@....com,
	airlied@...ux.ie, daniel@...ll.ch, qingqing.zhuo@....com,
	stylon.wang@....com, Josip.Pavic@....com, trix@...hat.com,
	cruise.hung@....com, Eric.Yang2@....com, mario.limonciello@....com,
	alvin.lee2@....com, jun.lei@....com, austin.zheng@....com,
	sunglee@....com, paul.hsieh@....com, hanghong.ma@....com,
	JinZe.Xu@....com, lewis.huang@....com, zhengzengkai@...wei.com,
	alex.hung@....com, syed.hassan@....com, wayne.lin@....com,
	nicholas.kazlauskas@....com, chiahsuan.chung@....com,
	aurabindo.pillai@....com, aric.cyr@....com,
	amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6.6] drm/amd/display: Wake DMCUB before executing GPINT
 commands

On Tue, Apr 16, 2024 at 03:52:40AM +0000, Zhu Wang wrote:
> From: Nicholas Kazlauskas <nicholas.kazlauskas@....com>
> 
> stable inclusion
> from stable-v6.7.3
> commit 2ef98c6d753a744e333b7e34b9cf687040fba57d
> category: bugfix
> bugzilla: https://gitee.com/src-openeuler/kernel/issues/I9BV4C
> CVE: CVE-2023-52624
> 
> Reference: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2ef98c6d753a744e333b7e34b9cf687040fba57d
> 
> --------------------------------
> 
> [ Upstream commit e5ffd1263dd5b44929c676171802e7b6af483f21 ]
> 
> [Why]
> DMCUB can be in idle when we attempt to interface with the HW through
> the GPINT mailbox resulting in a system hang.
> 
> [How]
> Add dc_wake_and_execute_gpint() to wrap the wake, execute, sleep
> sequence.
> 
> If the GPINT executes successfully then DMCUB will be put back into
> sleep after the optional response is returned.
> 
> It functions similar to the inbox command interface.
> 
> Cc: Mario Limonciello <mario.limonciello@....com>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: stable@...r.kernel.org
> Reviewed-by: Hansen Dsouza <hansen.dsouza@....com>
> Acked-by: Wayne Lin <wayne.lin@....com>
> Signed-off-by: Nicholas Kazlauskas <nicholas.kazlauskas@....com>
> Tested-by: Daniel Wheeler <daniel.wheeler@....com>
> Signed-off-by: Alex Deucher <alexander.deucher@....com>
> 
> This commit comes from following commits:
> 
>  8774029f76b9 ("drm/amd/display: Add DCN35 CLK_MGR")
>  65138eb72e1f ("drm/amd/display: Add DCN35 DMUB")
>  dc01c4b79bfe ("drm/amd/display: Update driver and IPS interop")
>  820c3870c491 ("drm/amd/display: Refactor DMCUB enter/exit idle interface")
>  2ef98c6d753a ("drm/amd/display: Wake DMCUB before executing GPINT commands")

Why are you putting multiple commits together and not just submitting
the individual ones?  And what is this for?

confused,

greg k-h