linux-kernel - Re: [PATCH] bpf: btf: include linux/types.h for u32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANXV_Xwmf-VH5EfNdv=wcv8J=2W5L5RtOs8n-Uh5jm5a1yiMKw@mail.gmail.com>
Date: Tue, 16 Apr 2024 08:27:21 +0300
From: Dmitrii Bundin <dmitrii.bundin.a@...il.com>
To: Jiri Olsa <olsajiri@...il.com>
Cc: linux-kernel@...r.kernel.org, bpf@...r.kernel.org, haoluo@...gle.com, 
	sdf@...gle.com, kpsingh@...nel.org, john.fastabend@...il.com, 
	yonghong.song@...ux.dev, song@...nel.org, eddyz87@...il.com, 
	andrii@...nel.org, daniel@...earbox.net, ast@...nel.org, martin.lau@...ux.dev, 
	khazhy@...omium.org, vmalik@...hat.com, ndesaulniers@...gle.com, 
	ncopa@...inelinux.org, dxu@...uu.xyz
Subject: Re: [PATCH] bpf: btf: include linux/types.h for u32

On Mon, Apr 15, 2024 at 3:11 PM Jiri Olsa <olsajiri@...il.com> wrote:
> lgtm, did it actualy cause problem anywhere?
>
> there's also tools/include/linux/btf_ids.h

It caused the problems exactly in the file
tools/include/linux/btf_ids.h and was reported in
https://bugzilla.kernel.org/show_bug.cgi?id=218647
The patch including linux/types.h in tools/include/linux/btf_ids.h is
already there https://lore.kernel.org/all/20240328110103.28734-1-ncopa@alpinelinux.org/
I also faced the same compile-error of the form

    error: unknown type name 'u32'
                              u32 cnt;
                              ^~~
when compiling the bpf tool with glibc 2.28.

I think it might be reasonable to add the inclusion in
include/linux/btf_ids.h as well to prevent build problems like this.