linux-kernel - Re: [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240416065026.GA4165@francesco-nb>
Date: Tue, 16 Apr 2024 08:50:26 +0200
From: Francesco Dolcini <francesco@...cini.it>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/10] arm64: dts: imx8qm-ss-audio: add audio nodes

Hello Frank,

On Mon, Apr 15, 2024 at 03:46:38PM -0400, Frank Li wrote:
> Add i.MX8QM audio related nodes and update eDMA[0,1]'s information.
> 
> Signed-off-by: Frank Li <Frank.Li@....com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi | 473 +++++++++++++++++++++
>  arch/arm64/boot/dts/freescale/imx8qm.dtsi          |  86 ++++
>  2 files changed, 559 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> new file mode 100644
> index 0000000000000..ed5a1b4af1d76
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-ss-audio.dtsi
> @@ -0,0 +1,473 @@
> +// SPDX-License-Identifier: GPL-2.0+

OR MIT?

Normally for device tree files having both is preferred.

> +/*
> + * Copyright 2024 NXP
> + *	Dong Aisheng <aisheng.dong@....com>
> + */
> +
> +/delete-node/ &acm;
> +/delete-node/ &sai4;
> +/delete-node/ &sai5;
> +/delete-node/ &sai4_lpcg;
> +/delete-node/ &sai5_lpcg;

Can you explain these delete-node ? This is something that I would
expect when a dtsi is previously included, not in this case.

Francesco