linux-kernel - Re: [PATCH 15/18] HID: picoLCD: Constify lcd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 16 Apr 2024 10:07:16 +0200
From: Bruno Prémont <bonbons@...ophe.eu>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Lee Jones <lee@...nel.org>, Daniel Thompson
 <daniel.thompson@...aro.org>, Jingoo Han <jingoohan1@...il.com>, Helge
 Deller <deller@....de>, Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires
 <bentiss@...nel.org>, Alexander Shiyan <shc_work@...l.ru>, Sascha Hauer
 <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>,
 Shawn Guo <shawnguo@...nel.org>, Fabio Estevam <festevam@...il.com>,
 dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, imx@...ts.linux.dev,
 linux-omap@...r.kernel.org
Subject: Re: [PATCH 15/18] HID: picoLCD: Constify lcd_ops

On Sun, 14 Apr 2024 18:36:13 +0200 Krzysztof Kozlowski wrote:
> 'struct lcd_ops' is not modified by core backlight code, so it can be
> made const for increased code safety.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Reviewed-by: Bruno Prémont <bonbons@...ux-vserver.org>

> ---
> 
> Depends on the first patch in the series.
> ---
>  drivers/hid/hid-picolcd_lcd.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c
> index 0c4b76de8ae5..061a33ba7b1d 100644
> --- a/drivers/hid/hid-picolcd_lcd.c
> +++ b/drivers/hid/hid-picolcd_lcd.c
> @@ -46,7 +46,7 @@ static int picolcd_check_lcd_fb(struct lcd_device *ldev, struct fb_info *fb)
>  	return fb && fb == picolcd_fbinfo((struct picolcd_data *)lcd_get_data(ldev));
>  }
>  
> -static struct lcd_ops picolcd_lcdops = {
> +static const struct lcd_ops picolcd_lcdops = {
>  	.get_contrast   = picolcd_get_contrast,
>  	.set_contrast   = picolcd_set_contrast,
>  	.check_fb       = picolcd_check_lcd_fb,
>