linux-kernel - Re: [PATCH v6 4/4] mm: correct the docs for thp_fault_alloc and thp_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e959e26b-41c9-47d0-bd74-f6493a354353@redhat.com>
Date: Tue, 16 Apr 2024 10:16:23 +0200
From: David Hildenbrand <david@...hat.com>
To: Barry Song <21cnbao@...il.com>, akpm@...ux-foundation.org,
 linux-mm@...ck.org
Cc: cerasuolodomenico@...il.com, chrisl@...nel.org, kasong@...cent.com,
 linux-kernel@...r.kernel.org, peterx@...hat.com, ryan.roberts@....com,
 surenb@...gle.com, v-songbaohua@...o.com, willy@...radead.org,
 yosryahmed@...gle.com, yuzhao@...gle.com, corbet@....net
Subject: Re: [PATCH v6 4/4] mm: correct the docs for thp_fault_alloc and
 thp_fault_fallback

On 12.04.24 13:48, Barry Song wrote:
> From: Barry Song <v-songbaohua@...o.com>
> 
> The documentation does not align with the code. In
> __do_huge_pmd_anonymous_page(), THP_FAULT_FALLBACK is incremented when
> mem_cgroup_charge() fails, despite the allocation succeeding, whereas
> THP_FAULT_ALLOC is only incremented after a successful charge.
> 
> Signed-off-by: Barry Song <v-songbaohua@...o.com>
> Reviewed-by: Ryan Roberts <ryan.roberts@....com>
> Cc: Chris Li <chrisl@...nel.org>
> Cc: David Hildenbrand <david@...hat.com>
> Cc: Domenico Cerasuolo <cerasuolodomenico@...il.com>
> Cc: Kairui Song <kasong@...cent.com>
> Cc: Matthew Wilcox (Oracle) <willy@...radead.org>
> Cc: Peter Xu <peterx@...hat.com>
> Cc: Ryan Roberts <ryan.roberts@....com>
> Cc: Suren Baghdasaryan <surenb@...gle.com>
> Cc: Yosry Ahmed <yosryahmed@...gle.com>
> Cc: Yu Zhao <yuzhao@...gle.com>
> Cc: Jonathan Corbet <corbet@....net>
> ---

Reviewed-by: David Hildenbrand <david@...hat.com>

-- 
Cheers,

David / dhildenb