| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <be056435353af60a564f457c79dacc16c6ea920e.camel@redhat.com>
Date: Tue, 16 Apr 2024 10:18:42 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Kuniyuki Iwashima <kuniyu@...zon.com>,
devnull+j.granados.samsung.com@...nel.org
Cc: Dai.Ngo@...cle.com, alex.aring@...il.com, alibuda@...ux.alibaba.com,
allison.henderson@...cle.com, anna@...nel.org, bridge@...ts.linux.dev,
chuck.lever@...cle.com, coreteam@...filter.org, courmisch@...il.com,
davem@...emloft.net, dccp@...r.kernel.org, dhowells@...hat.com,
dsahern@...nel.org, edumazet@...gle.com, fw@...len.de, geliang@...nel.org,
guwen@...ux.alibaba.com, herbert@...dor.apana.org.au, horms@...ge.net.au,
j.granados@...sung.com, ja@....bg, jaka@...ux.ibm.com, jlayton@...nel.org,
jmaloy@...hat.com, jreuter@...na.de, kadlec@...filter.org,
keescook@...omium.org, kolga@...app.com, kuba@...nel.org,
linux-afs@...ts.infradead.org, linux-hams@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-nfs@...r.kernel.org,
linux-rdma@...r.kernel.org, linux-s390@...r.kernel.org,
linux-sctp@...r.kernel.org, linux-wpan@...r.kernel.org,
linux-x25@...r.kernel.org, lucien.xin@...il.com, lvs-devel@...r.kernel.org,
marc.dionne@...istor.com, marcelo.leitner@...il.com, martineau@...nel.org,
matttbe@...nel.org, mcgrof@...nel.org, miquel.raynal@...tlin.com,
mptcp@...ts.linux.dev, ms@....tdt.de, neilb@...e.de,
netdev@...r.kernel.org, netfilter-devel@...r.kernel.org,
pablo@...filter.org, ralf@...ux-mips.org, razor@...ckwall.org,
rds-devel@....oracle.com, roopa@...dia.com, stefan@...enfreihafen.org,
steffen.klassert@...unet.com, tipc-discussion@...ts.sourceforge.net,
tom@...pey.com, tonylu@...ux.alibaba.com, trond.myklebust@...merspace.com,
wenjia@...ux.ibm.com, ying.xue@...driver.com
Subject: Re: [PATCH v3 1/4] networking: Remove the now superfluous sentinel
elements from ctl_table array
On Mon, 2024-04-15 at 16:12 -0700, Kuniyuki Iwashima wrote:
> From: Joel Granados via B4 Relay <devnull+j.granados.samsung.com@...nel.org>
> Date: Fri, 12 Apr 2024 16:48:29 +0200
> > From: Joel Granados <j.granados@...sung.com>
> >
> > This commit comes at the tail end of a greater effort to remove the
> > empty elements at the end of the ctl_table arrays (sentinels) which
> > will reduce the overall build time size of the kernel and run time
> > memory bloat by ~64 bytes per sentinel (further information Link :
> > https://lore.kernel.org/all/ZO5Yx5JFogGi%2FcBo@bombadil.infradead.org/)
> >
> > * Remove sentinel element from ctl_table structs.
> > * Remove extra element in ctl_table arrays declarations
> > * Remove instances where an array element is zeroed out to make it look
> > like a sentinel. This is not longer needed and is safe after commit
> > c899710fe7f9 ("networking: Update to register_net_sysctl_sz") added
> > the array size to the ctl_table registration
> > * Replace the for loop stop condition that tests for procname == NULL with
> > one that depends on array size
> > * Removed the "-1" that adjusted for having an extra empty element when
> > looping over ctl_table arrays
> > * Removing the unprivileged user check in ipv6_route_sysctl_init is
> > safe as it is replaced by calling ipv6_route_sysctl_table_size;
> > introduced in commit c899710fe7f9 ("networking: Update to
> > register_net_sysctl_sz")
> > * Replace empty array registration with the register_net_sysctl_sz call.
> >
> > Signed-off-by: Joel Granados <j.granados@...sung.com>
> > ---
> > net/core/neighbour.c | 5 +----
> > net/core/sysctl_net_core.c | 9 ++++-----
> > net/dccp/sysctl.c | 2 --
> > net/ieee802154/6lowpan/reassembly.c | 6 +-----
> > net/ipv4/devinet.c | 5 ++---
> > net/ipv4/ip_fragment.c | 2 --
> > net/ipv4/route.c | 8 ++------
> > net/ipv4/sysctl_net_ipv4.c | 7 +++----
> > net/ipv4/xfrm4_policy.c | 1 -
> > net/ipv6/addrconf.c | 5 +----
> > net/ipv6/icmp.c | 1 -
> > net/ipv6/reassembly.c | 2 --
> > net/ipv6/route.c | 5 -----
> > net/ipv6/sysctl_net_ipv6.c | 4 +---
> > net/ipv6/xfrm6_policy.c | 1 -
> > net/llc/sysctl_net_llc.c | 8 ++------
> > net/mpls/af_mpls.c | 3 +--
> > net/mptcp/ctrl.c | 1 -
> > net/netrom/sysctl_net_netrom.c | 1 -
> > net/phonet/sysctl.c | 1 -
> > net/rds/ib_sysctl.c | 1 -
> > net/rds/sysctl.c | 1 -
> > net/rds/tcp.c | 1 -
> > net/rose/sysctl_net_rose.c | 1 -
> > net/rxrpc/sysctl.c | 1 -
> > net/sctp/sysctl.c | 6 +-----
> > net/smc/smc_sysctl.c | 1 -
> > net/sunrpc/sysctl.c | 1 -
> > net/sunrpc/xprtrdma/svc_rdma.c | 1 -
> > net/sunrpc/xprtrdma/transport.c | 1 -
> > net/sunrpc/xprtsock.c | 1 -
> > net/tipc/sysctl.c | 1 -
> > net/unix/sysctl_net_unix.c | 1 -
> > net/x25/sysctl_net_x25.c | 1 -
> > net/xfrm/xfrm_sysctl.c | 5 +----
> > 35 files changed, 20 insertions(+), 81 deletions(-)
>
> You may want to split patch based on subsystem or the type of changes
> to make review easier.
I agree with Kuniyuki. I think the x25 chunks can me moved in the last
patch, and at least sunrpc and rds could go in separate patches,
possibly even xfrm and smc.
Thanks,
Paolo
Powered by blists - more mailing lists