linux-kernel - [PATCH v2 0/7] Remove on-stack cpumask var for irq subsystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20240416085454.3547175-1-dawei.li@shingroup.cn>
Date: Tue, 16 Apr 2024 16:54:47 +0800
From: Dawei Li <dawei.li@...ngroup.cn>
To: tglx@...utronix.de,
	yury.norov@...il.com,
	rafael@...nel.org
Cc: akpm@...ux-foundation.org,
	maz@...nel.org,
	florian.fainelli@...adcom.com,
	chenhuacai@...nel.org,
	jiaxun.yang@...goat.com,
	anup@...infault.org,
	palmer@...belt.com,
	samuel.holland@...ive.com,
	linux@...musvillemoes.dk,
	daniel.lezcano@...aro.org,
	linux-kernel@...r.kernel.org,
	Dawei Li <dawei.li@...ngroup.cn>
Subject: [PATCH v2 0/7] Remove on-stack cpumask var for irq subsystem 

Hi,

This is v2 of previous series[1] on removal of onstack cpumask var.

Generally it's preferable to avoid placing cpumasks on the stack, as
for large values of NR_CPUS these can consume significant amounts of
stack space and make stack overflows more likely.

One may argue that alloc_cpumask_var() and its friends are the formal
way for these cases. But for struct irqchip::irq_set_affinity(), it's
called under atomic context(raw spinlock held), and dynamic memory
allocation in atomic context is less-favorable.

So a new helper is introduced to address all these issues above. It's
free of any context issue and intermediate cpumask variable allocation
issue(no matter it's on stack or heap).

The case with gic-v3-its(Patch 3) is special from others since it's not
related to intersections between 3 cpumask.

Patch#7 is not for irq subsystem, it's in this series only because it
uses new helper. Please ignore it if you found it's inappropriate for
this series.

Any comments are welcomed.

------------

Change since v1:

- Rebased against tip/irq/core;

- Patch[1]: [Yury]
  - Remove ifdefery nesting on find_first_and_and_bit; 
  - Update commit message;

- Patch[3]: [Marc]
  - Merge two bitmap ops into one;
  - Update commit message;

- Patch[2,4-6]: [Yury]
  - Unwrap lines;

- Patch[7]:
  Newly added. Feel free to drop/ignore it if you found it's inappropriate
  for this series.

[1] v1:
https://lore.kernel.org/lkml/20240412105839.2896281-1-dawei.li@shingroup.cn/

Dawei Li (7):
  cpumask: introduce cpumask_first_and_and()
  irqchip/irq-bcm6345-l1: Avoid explicit cpumask allocation on stack
  irqchip/gic-v3-its: Avoid explicit cpumask allocation on stack
  irqchip/loongson-eiointc: Avoid explicit cpumask allocation on stack
  irqchip/riscv-aplic-direct: Avoid explicit cpumask allocation on stack
  irqchip/sifive-plic: Avoid explicit cpumask allocation on stack
  cpuidle: Avoid explicit cpumask allocation on stack

 drivers/cpuidle/coupled.c                | 13 +++---------
 drivers/irqchip/irq-bcm6345-l1.c         |  6 +-----
 drivers/irqchip/irq-gic-v3-its.c         | 15 ++++++++-----
 drivers/irqchip/irq-loongson-eiointc.c   |  8 ++-----
 drivers/irqchip/irq-riscv-aplic-direct.c |  7 ++----
 drivers/irqchip/irq-sifive-plic.c        |  7 ++----
 include/linux/cpumask.h                  | 17 +++++++++++++++
 include/linux/find.h                     | 27 ++++++++++++++++++++++++
 lib/find_bit.c                           | 12 +++++++++++
 9 files changed, 76 insertions(+), 36 deletions(-)

base-commit: 35d77eb7b974f62aaef5a0dc72d93ddb1ada4074

Thanks,

    Dawei

-- 
2.27.0